Bug 117744 – REGRESSION (r151451): Text not vertically centered correctly on icloud.com

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Beth Dakin]

* SUMMARY
http://icloud.com no longer has the username/password text centered after http://trac.webkit.org/changeset/151451

* STEPS TO REPRODUCE
1. Go to http://icloud.com
2. Enter in a username

* RESULTS
Text is not centered vertically. It should be.

<rdar://problem/14189756>

[Simon Fraser (smfr)]

Created attachment 204927 [details]
Screenshot

[Robert Hogan]

Created attachment 204935 [details]
Patch

[Robert Hogan]

*** Bug 117745 has been marked as a duplicate of this bug. ***

[Build Bot]

Comment on attachment 204935 [details]
Patch

Attachment 204935 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/943049

New failing tests:
fast/forms/input-appearance-preventDefault.html
fast/forms/onselect-textfield.html
fast/replaced/width-and-height-of-positioned-replaced-elements.html

[Build Bot]

Created attachment 204951 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 204935 [details]
Patch

Attachment 204935 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/869260

New failing tests:
fast/forms/input-appearance-preventDefault.html
fast/replaced/width-and-height-of-positioned-replaced-elements.html

[Build Bot]

Created attachment 204957 [details]
Archive of layout-test-results from APPLE-EWS-3 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-3  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

[Dave Hyatt]

Comment on attachment 204935 [details]
Patch

r=me

[Robert Hogan]

Created attachment 205026 [details]
Patch

Patch For Landing

[Build Bot]

Comment on attachment 205026 [details]
Patch

Attachment 205026 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/934302

New failing tests:
fast/media/mq-transform-03.html
fast/media/mq-transform-02.html
platform/win/accessibility/multiple-select-element-role.html

[Build Bot]

Created attachment 205038 [details]
Archive of layout-test-results from APPLE-EWS-6 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-6  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

[WebKit Commit Bot]

Comment on attachment 205026 [details]
Patch

Rejecting attachment 205026 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 205026, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
atching file LayoutTests/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt
patching file LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.txt
LayoutTests/platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png already exists at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 258.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 25 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/934499

[WebKit Commit Bot]

Comment on attachment 205026 [details]
Patch

Rejecting attachment 205026 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 205026, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
atching file LayoutTests/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt
patching file LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.txt
LayoutTests/platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png already exists at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 258.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 25 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/871239

[Robert Hogan]

Committed r151788: <http://trac.webkit.org/changeset/151788>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 117847

[Robert Hogan]

This was the wrong fix I think. I'm going to do the proper one at bug 117845. The fix is kind of speculative since I can't recreate the issue reported on Qt. However the issue I intend to remedy at 117845 is a very likely culprit.

[Robert Hogan]

r151451 was rolled out: http://trac.webkit.org/changeset/151799

[Robert Hogan]

(In reply to comment #17)
> r151451 was rolled out: http://trac.webkit.org/changeset/151799

This change was rolled in again with r154826 and should have fixed the issue encountered in this bug. While I was able to recreate the centering issues on other reported sites on my non-Mac build, I was never able to recreate the one on iCloud.com - so Beth could you confirm that it is not an issue anymore?

[Tim Horton]

(In reply to comment #18)
> (In reply to comment #17)
> > r151451 was rolled out: http://trac.webkit.org/changeset/151799
> 
> This change was rolled in again with r154826 and should have fixed the issue encountered in this bug. While I was able to recreate the centering issues on other reported sites on my non-Mac build, I was never able to recreate the one on iCloud.com - so Beth could you confirm that it is not an issue anymore?

It is still an issue - that is, on ToT, the iCloud.com login page text field text is too high, as in smfr's screenshot.

[Alexey Proskuryakov]

Looks like it got rolled out again?

[Robert Hogan]

Yup..