Bug 117726 – Synthesized vertical italics on rotated glyphs are transformed incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Dean Jackson]

Created attachment 204882 [details]
Test Case

See the testcase. If a document is using vertical layout, and italics, and using a font that does not provide italic glyphs, then the synthesis of italics skews in the wrong direction.

<rdar://problem/12783606>

[Dean Jackson]

Created attachment 204883 [details]
Patch

[Early Warning System Bot]

Comment on attachment 204883 [details]
Patch

Attachment 204883 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/937247

[Early Warning System Bot]

Comment on attachment 204883 [details]
Patch

Attachment 204883 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/884197

[Eric Carlson]

Comment on attachment 204883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204883&action=review

> Source/WebCore/platform/graphics/FontGlyphs.cpp:207
> +    RefPtr<SimpleFontData> nonItalicFontData = data.fontData->nonSyntheticItalicFontData();
> +    GlyphPageTreeNode* nonItalicNode = GlyphPageTreeNode::getRootChild(nonItalicFontData.get(), pageNumber);
> +    GlyphPage* nonItalicPage = nonItalicNode->page();

Nit: these aren't used if page is NULL.

[Dean Jackson]

(In reply to comment #4)
> (From update of attachment 204883 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204883&action=review
> 
> > Source/WebCore/platform/graphics/FontGlyphs.cpp:207
> > +    RefPtr<SimpleFontData> nonItalicFontData = data.fontData->nonSyntheticItalicFontData();
> > +    GlyphPageTreeNode* nonItalicNode = GlyphPageTreeNode::getRootChild(nonItalicFontData.get(), pageNumber);
> > +    GlyphPage* nonItalicPage = nonItalicNode->page();
> 
> Nit: these aren't used if page is NULL.

That was a typo. It should have been if (nonItalicPage).

Thanks for noticing!

[Enrica Casucci]

Comment on attachment 204883 [details]
Patch

Looks good to me, with the change Eric pointed out. I trust you to fix the 2 qt builds before landing the patch.

[Dean Jackson]

Created attachment 204932 [details]
Patch

[Dean Jackson]

Committed r151693: <http://trac.webkit.org/changeset/151693>