Bug 117725 - [Qt][WK2] memory leak in QQuickWebView
Summary: [Qt][WK2] memory leak in QQuickWebView
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-17 22:23 PDT by Sangho Kim
Modified: 2014-02-03 03:26 PST (History)
7 users (show)

See Also:

Attachments
patch (1.54 KB, patch)
2013-06-17 22:37 PDT, Sangho Kim 		no flags Details | Formatted Diff | Diff
patch (1.66 KB, patch)
2013-06-21 01:24 PDT, Sangho Kim 		no flags Details | Formatted Diff | Diff
patch (2.67 KB, patch)
2013-06-23 18:13 PDT, Sangho Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sangho Kim 2013-06-17 22:23:57 PDT 
There are QQuickWebViewExperimental pointer in QQuickWebView.
The constructor of QQuickWebView new QQuickWebViewExperimental. But the destructor doesn't delete this.
Comment 1 Sangho Kim 2013-06-17 22:37:06 PDT 
Created attachment 204881 [details]
patch

adding delete clase...
Comment 2 WebKit Commit Bot 2013-06-17 22:37:26 PDT 
Comment on attachment 204881 [details]
patch

Rejecting attachment 204881 [details] from commit-queue.

thomas.kim@lge.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 Sergio Villar Senin 2013-06-21 00:55:02 PDT 
Comment on attachment 204881 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204881&action=review

Overall looks good, some Qt reviewer should take a look though. Some nits

> Source/WebKit2/ChangeLog:7
> +

You need to include a short description of the patch here.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:319
> +    if (experimental)

Why if? Isn't it always created?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1057
> +    if (schemeParent)

Same question here about the if.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1059
> +    if (m_test)

Ditto.
Comment 4 Sangho Kim 2013-06-21 01:24:51 PDT 
Created attachment 205158 [details]
patch

changed the ChangeLog and delete if phrase.
Comment 5 Rafael Brandao 2013-06-21 10:04:23 PDT 
Comment on attachment 204881 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204881&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:320
> +        delete experimental;

If this fix is right, then it seems that you need to use an OwnPtr on QQuickWebViewPrivate rather than a raw pointer.
Comment 6 Sangho Kim 2013-06-23 18:13:48 PDT 
Created attachment 205274 [details]
patch

change raw pointer to OwnPtr of QQuickWebViewExperimental
Comment 7 Sangho Kim 2013-09-04 21:33:14 PDT 
Please review and commit...
Comment 8 Anders Carlsson 2013-10-02 21:35:46 PDT 
Qt has been removed, clearing review flags.
Comment 9 Jocelyn Turcotte 2014-02-03 03:26:12 PST 
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.