Bug 117711 - [CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
Summary: [CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-17 11:48 PDT by Ralph T
Modified: 2013-06-20 11:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.87 KB, patch)
2013-06-17 11:51 PDT, Ralph T 		no flags Details | Formatted Diff | Diff
Patch (2.72 KB, patch)
2013-06-18 12:27 PDT, Ralph T 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph T 2013-06-17 11:48:59 PDT 
[CMake][CSS Shaders] Conditionally add WebCore files for CSS Shaders to CMakeLists.txt
Comment 1 Ralph T 2013-06-17 11:51:44 PDT 
Created attachment 204845 [details]
Patch
Comment 2 Ralph T 2013-06-18 08:19:51 PDT 
Comment on attachment 204845 [details]
Patch

Since all of the files included are guarded with #if ENABLE(CSS_SHADERS) I can just add them to WebCore_SOURCES unconditionally -- I'll submit a new patch that does this later today. Thanks to Patrick Gansterer and Raphael Kubo da Costa for review.
Comment 3 Ralph T 2013-06-18 12:27:44 PDT 
Created attachment 204929 [details]
Patch
Comment 4 Ralph T 2013-06-18 12:37:32 PDT 
New patch adds files to the build unconditionally, since they're all guarded with #if ENABLE(CSS_SHADERS).
Comment 5 Laszlo Gombos 2013-06-20 09:09:56 PDT 
Comment on attachment 204929 [details]
Patch

r=me.
Comment 6 WebKit Commit Bot 2013-06-20 11:08:10 PDT 
Comment on attachment 204929 [details]
Patch

Clearing flags on attachment: 204929

Committed r151784: <http://trac.webkit.org/changeset/151784>
Comment 7 WebKit Commit Bot 2013-06-20 11:08:14 PDT 
All reviewed patches have been landed.  Closing bug.