Bug 117710 - fourthTier: DFG should have switch_char
Summary: fourthTier: DFG should have switch_char
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-17 11:45 PDT by Filip Pizlo
Modified: 2013-06-20 10:54 PDT (History)
7 users (show)

See Also:

Attachments
work in progress (15.75 KB, patch)
2013-06-17 11:46 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
it compiles! (36.67 KB, patch)
2013-06-17 16:00 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (47.51 KB, patch)
2013-06-18 08:40 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
patch for landing (53.48 KB, patch)
2013-06-18 11:05 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-06-17 11:45:31 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-06-17 11:46:15 PDT 
Created attachment 204844 [details]
work in progress
Comment 2 Filip Pizlo 2013-06-17 16:00:37 PDT 
Created attachment 204863 [details]
it compiles!
Comment 3 Filip Pizlo 2013-06-18 08:40:30 PDT 
Created attachment 204918 [details]
the patch
Comment 4 Michael Saboff 2013-06-18 10:09:09 PDT 
Comment on attachment 204918 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204918&action=review

> Source/WTF/ChangeLog:11
> +        Also made it possible to convert a UChar to a utf8 CString without
> +        allocating a StringImpl.

Since this is only used with dump() methods, why do we care about allocating a StringImpl?
Comment 5 Filip Pizlo 2013-06-18 10:39:34 PDT 
(In reply to comment #4)
> (From update of attachment 204918 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204918&action=review
> 
> > Source/WTF/ChangeLog:11
> > +        Also made it possible to convert a UChar to a utf8 CString without
> > +        allocating a StringImpl.
> 
> Since this is only used with dump() methods, why do we care about allocating a StringImpl?

Because you cannot ref/deref StringImpl's on the compiler thread, which implicitly means you cannot allocate them.  That's an important assertion, since StringImpl's aren't thread-safe ref-counted.  So we want to keep that assertion; but to keep it, we can't allocate StringImpls in the compiler thread.
Comment 6 Filip Pizlo 2013-06-18 11:05:55 PDT 
Created attachment 204925 [details]
patch for landing

Now including tests.
Comment 7 Filip Pizlo 2013-06-20 10:54:46 PDT 
Landed in http://trac.webkit.org/changeset/151781