Bug 117698 – [New multicol] Change test to follow the pattern of the other tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Mihai Maerean]

Change LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html to follow the pattern of the other tests: the expected result is using the old multicol code.

[Mihai Maerean]

Created attachment 204826 [details]
patch

test is a ref test against the old multicol code, like all the other tests in LayoutTests/fast/multicol/newmulticol/

[Zoltan Horvath]

Comment on attachment 204826 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204826&action=review

> LayoutTests/ChangeLog:3
> +        [New multicol] Change test to follow the pattern of the other tests

I would call this bug to something like: Turn fast/multicol/newmulticol/direct-child-column-span-all.html into a reftest

> LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.html:13
> +		test passes if it doesn't crash or assert.

Since you have a reftest now I would add a small explanation what is happening here (description of http://trac.webkit.org/changeset/150611) and a reference to the original bug where the test has been added (https://bugs.webkit.org/show_bug.cgi?id=116614), so we can easily see what's going on if it fails in the future.

[Mihai Maerean]

Created attachment 204884 [details]
patch that integrates the feedback from Zoltan.

[WebKit Commit Bot]

Comment on attachment 204884 [details]
patch that integrates the feedback from Zoltan.

Clearing flags on attachment: 204884

Committed r152413: <http://trac.webkit.org/changeset/152413>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.