Bug 117698 - [New multicol] Change test to follow the pattern of the other tests
Summary: [New multicol] Change test to follow the pattern of the other tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihai Maerean
URL:
Keywords:
Depends on: 116614
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-17 08:37 PDT by Mihai Maerean
Modified: 2013-07-05 03:27 PDT (History)
2 users (show)

See Also:

Attachments
patch (2.47 KB, patch)
2013-06-17 08:49 PDT, Mihai Maerean 		no flags Details | Formatted Diff | Diff
patch that integrates the feedback from Zoltan. (3.79 KB, patch)
2013-06-17 23:56 PDT, Mihai Maerean 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Maerean 2013-06-17 08:37:17 PDT 
Change LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html to follow the pattern of the other tests: the expected result is using the old multicol code.
Comment 1 Mihai Maerean 2013-06-17 08:49:26 PDT 
Created attachment 204826 [details]
patch

test is a ref test against the old multicol code, like all the other tests in LayoutTests/fast/multicol/newmulticol/
Comment 2 Zoltan Horvath 2013-06-17 15:38:52 PDT 
Comment on attachment 204826 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204826&action=review

> LayoutTests/ChangeLog:3
> +        [New multicol] Change test to follow the pattern of the other tests

I would call this bug to something like: Turn fast/multicol/newmulticol/direct-child-column-span-all.html into a reftest

> LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.html:13
> +		test passes if it doesn't crash or assert.

Since you have a reftest now I would add a small explanation what is happening here (description of http://trac.webkit.org/changeset/150611) and a reference to the original bug where the test has been added (https://bugs.webkit.org/show_bug.cgi?id=116614), so we can easily see what's going on if it fails in the future.
Comment 3 Mihai Maerean 2013-06-17 23:56:36 PDT 
Created attachment 204884 [details]
patch that integrates the feedback from Zoltan.
Comment 4 WebKit Commit Bot 2013-07-05 03:27:29 PDT 
Comment on attachment 204884 [details]
patch that integrates the feedback from Zoltan.

Clearing flags on attachment: 204884

Committed r152413: <http://trac.webkit.org/changeset/152413>
Comment 5 WebKit Commit Bot 2013-07-05 03:27:31 PDT 
All reviewed patches have been landed.  Closing bug.