Bug 117696 - [Mac] Sort all the Xcode project files
Summary: [Mac] Sort all the Xcode project files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-17 08:05 PDT by Darin Adler
Modified: 2013-06-23 17:40 PDT (History)
2 users (show)

See Also:

Attachments
Patch (169.83 KB, patch)
2013-06-17 08:08 PDT, Darin Adler 		andersca: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-06-17 08:05:32 PDT 
Sort all the Xcode project files
Comment 1 Darin Adler 2013-06-17 08:08:27 PDT 
Created attachment 204824 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-17 08:10:55 PDT 
Attachment 204824 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ChangeLog', u'Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj', u'Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebInspectorUI/ChangeLog', u'Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj:458:  Missing "developmentRegion = English".  [xcodeproj/settings] [5]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2013-06-18 18:21:49 PDT 
Comment on attachment 204824 [details]
Patch

Rejecting attachment 204824 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 204824, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
t 4 lines).
Hunk #56 succeeded at 7005 (offset 4 lines).
Hunk #57 succeeded at 7054 (offset 4 lines).
Hunk #58 succeeded at 7083 (offset 4 lines).
Hunk #59 succeeded at 7099 (offset 4 lines).
Hunk #60 succeeded at 7162 (offset 4 lines).
1 out of 60 hunks FAILED -- saving rejects to file Source/WebKit2/WebKit2.xcodeproj/project.pbxproj.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Anders Carlsson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/942112
Comment 4 Darin Adler 2013-06-23 17:40:31 PDT 
Committed r151888: <http://trac.webkit.org/changeset/151888>