Bug 117691 - Move ProximityClient to WebCore/platform
Summary: Move ProximityClient to WebCore/platform
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kihong Kwon
URL:
Keywords:
Depends on:
Blocks: 92837
  Show dependency treegraph
 
Reported: 2013-06-17 01:04 PDT by Kihong Kwon
Modified: 2013-06-21 10:37 PDT (History)
7 users (show)

See Also:


Attachments
Patch (23.79 KB, patch)
2013-06-17 01:29 PDT, Kihong Kwon
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-3 for win-future (792.24 KB, application/zip)
2013-06-17 05:41 PDT, Build Bot
no flags Details
Patch (22.82 KB, patch)
2013-06-18 21:18 PDT, Kihong Kwon
sam: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kihong Kwon 2013-06-17 01:04:19 PDT
Proximity Event doesn't have user interaction.
Therefore its proper position is WebCore/platform.
In addition, adding DeviceProximityClientEfl.cpp for specific implementation.
If other port want to add client for Device Proxmity Event,
DeviceProxmityClientXXX need to add under WebCore/platform/XXX.
Comment 1 Kihong Kwon 2013-06-17 01:29:20 PDT
Created attachment 204800 [details]
Patch
Comment 2 Build Bot 2013-06-17 05:41:11 PDT
Comment on attachment 204800 [details]
Patch

Attachment 204800 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/888024

New failing tests:
fast/media/mq-transform-03.html
fast/media/mq-transform-02.html
platform/win/accessibility/multiple-select-element-role.html
Comment 3 Build Bot 2013-06-17 05:41:14 PDT
Created attachment 204811 [details]
Archive of layout-test-results from APPLE-EWS-3 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-3  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 4 Kihong Kwon 2013-06-18 21:18:48 PDT
Created attachment 204969 [details]
Patch
Comment 5 Anders Carlsson 2013-06-19 06:28:16 PDT
Why is this moving to WebCore? Is it planned to be used in WebCore?
Comment 6 Kihong Kwon 2013-06-19 19:43:59 PDT
(In reply to comment #5)
> Why is this moving to WebCore? Is it planned to be used in WebCore?

Efl need to support Device Proximity Event. 
But we couldn't support this on the WK2(Bug 116860)
And IMHO, WebCore/platform is good to support Proximity Event because there is no user interaction on it.
Comment 7 Sam Weinig 2013-06-20 09:08:49 PDT
Comment on attachment 204969 [details]
Patch

This adds a layering violation. Thins in WebCore/platform cannot reference Page.
Comment 8 Kihong Kwon 2013-06-21 03:10:54 PDT
(In reply to comment #7)
> (From update of attachment 204969 [details])
> This adds a layering violation. Thins in WebCore/platform cannot reference Page.

You are right. I'm drop Page reference. Thank you.
Comment 9 Anders Carlsson 2013-06-21 10:37:53 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > Why is this moving to WebCore? Is it planned to be used in WebCore?
> 
> Efl need to support Device Proximity Event. 
> But we couldn't support this on the WK2(Bug 116860)
> And IMHO, WebCore/platform is good to support Proximity Event because there is no user interaction on it.

I don’t think this qualifies as going into platform.