NEW 117691
Move ProximityClient to WebCore/platform 
https://bugs.webkit.org/show_bug.cgi?id=117691
Summary Move ProximityClient to WebCore/platform
Kihong Kwon
Reported 2013-06-17 01:04:19 PDT
Proximity Event doesn't have user interaction. Therefore its proper position is WebCore/platform. In addition, adding DeviceProximityClientEfl.cpp for specific implementation. If other port want to add client for Device Proxmity Event, DeviceProxmityClientXXX need to add under WebCore/platform/XXX.
Attachments
Patch (23.79 KB, patch)
2013-06-17 01:29 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from APPLE-EWS-3 for win-future (792.24 KB, application/zip)
2013-06-17 05:41 PDT, Build Bot 		no flags
Details
Patch (22.82 KB, patch)
2013-06-18 21:18 PDT, Kihong Kwon 		sam: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kihong Kwon
Comment 1 2013-06-17 01:29:20 PDT
Created attachment 204800 [details] Patch
Build Bot
Comment 2 2013-06-17 05:41:11 PDT
Comment on attachment 204800 [details] Patch Attachment 204800 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/888024 New failing tests: fast/media/mq-transform-03.html fast/media/mq-transform-02.html platform/win/accessibility/multiple-select-element-role.html
Build Bot
Comment 3 2013-06-17 05:41:14 PDT
Created attachment 204811 [details] Archive of layout-test-results from APPLE-EWS-3 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-3 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Kihong Kwon
Comment 4 2013-06-18 21:18:48 PDT
Created attachment 204969 [details] Patch
Anders Carlsson
Comment 5 2013-06-19 06:28:16 PDT
Why is this moving to WebCore? Is it planned to be used in WebCore?
Kihong Kwon
Comment 6 2013-06-19 19:43:59 PDT
(In reply to comment #5) > Why is this moving to WebCore? Is it planned to be used in WebCore? Efl need to support Device Proximity Event. But we couldn't support this on the WK2(Bug 116860) And IMHO, WebCore/platform is good to support Proximity Event because there is no user interaction on it.
Sam Weinig
Comment 7 2013-06-20 09:08:49 PDT
Comment on attachment 204969 [details] Patch This adds a layering violation. Thins in WebCore/platform cannot reference Page.
Kihong Kwon
Comment 8 2013-06-21 03:10:54 PDT
(In reply to comment #7) > (From update of attachment 204969 [details]) > This adds a layering violation. Thins in WebCore/platform cannot reference Page. You are right. I'm drop Page reference. Thank you.
Anders Carlsson
Comment 9 2013-06-21 10:37:53 PDT
(In reply to comment #6) > (In reply to comment #5) > > Why is this moving to WebCore? Is it planned to be used in WebCore? > > Efl need to support Device Proximity Event. > But we couldn't support this on the WK2(Bug 116860) > And IMHO, WebCore/platform is good to support Proximity Event because there is no user interaction on it. I don’t think this qualifies as going into platform.
Note You need to log in before you can comment on or make changes to this bug.