Bug 117687 - [BlackBerry] only notify download client when download error
Summary: [BlackBerry] only notify download client when download error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mary Wu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-16 23:32 PDT by Mary Wu
Modified: 2013-06-18 02:13 PDT (History)
5 users (show)

See Also:

Attachments
webkit patch (5.01 KB, patch)
2013-06-17 00:38 PDT, Mary Wu 		no flags Details | Formatted Diff | Diff
patch (2.13 KB, patch)
2013-06-17 00:40 PDT, Mary Wu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mary Wu 2013-06-16 23:32:36 PDT 
when met network error in downloading, we notify the error to download client through download stream, we shouldn't notify page client the error.
Comment 1 Mary Wu 2013-06-17 00:38:23 PDT 
Created attachment 204798 [details]
webkit patch
Comment 2 Mary Wu 2013-06-17 00:40:13 PDT 
Created attachment 204799 [details]
patch

correct patch
Comment 3 Rob Buis 2013-06-17 07:03:17 PDT 
Comment on attachment 204799 [details]
patch

LGTM.
Comment 4 Mary Wu 2013-06-18 01:53:19 PDT 
Comment on attachment 204799 [details]
patch

thanks, Rob
Comment 5 WebKit Commit Bot 2013-06-18 02:13:34 PDT 
Comment on attachment 204799 [details]
patch

Clearing flags on attachment: 204799

Committed r151677: <http://trac.webkit.org/changeset/151677>
Comment 6 WebKit Commit Bot 2013-06-18 02:13:36 PDT 
All reviewed patches have been landed.  Closing bug.