Bug 117685 - Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()
Summary: Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-06-16 18:33 PDT by Gyuyoung Kim
Modified: 2013-06-16 20:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2013-06-16 18:37 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (1.41 KB, patch)
2013-06-16 20:16 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-06-16 18:33:35 PDT 
Avoid duplicating hostWindow() call. Merge with https://src.chromium.org/viewvc/blink?view=rev&revision=152490
Comment 1 Gyuyoung Kim 2013-06-16 18:37:43 PDT 
Created attachment 204794 [details]
Patch
Comment 2 Gyuyoung Kim 2013-06-16 18:38:53 PDT 
CC'ing Kling. could you take a look at this ?
Comment 3 Andreas Kling 2013-06-16 19:30:20 PDT 
Comment on attachment 204794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204794&action=review

r=me

> Source/WebCore/ChangeLog:3
> +        Minor refactoring with FrameView::InvalidateRect() for hostWindow call

The title of this bug doesn't really tell us anything. Any code change could be considered a "minor refactoring."
FWIW, I'd call this something like "Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()"
Comment 4 Gyuyoung Kim 2013-06-16 20:16:30 PDT 
Created attachment 204796 [details]
Patch for landing
Comment 5 Gyuyoung Kim 2013-06-16 20:17:37 PDT 
(In reply to comment #3)
> (From update of attachment 204794 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204794&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:3
> > +        Minor refactoring with FrameView::InvalidateRect() for hostWindow call
> 
> The title of this bug doesn't really tell us anything. Any code change could be considered a "minor refactoring."
> FWIW, I'd call this something like "Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()"

Ok, thanks. I fixed.
Comment 6 WebKit Commit Bot 2013-06-16 20:56:57 PDT 
Comment on attachment 204796 [details]
Patch for landing

Clearing flags on attachment: 204796

Committed r151628: <http://trac.webkit.org/changeset/151628>
Comment 7 WebKit Commit Bot 2013-06-16 20:56:59 PDT 
All reviewed patches have been landed.  Closing bug.