Bug 117676 - Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy
Summary: Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-15 17:06 PDT by Filip Pizlo
Modified: 2013-06-15 18:49 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.56 KB, patch)
2013-06-15 17:08 PDT, Filip Pizlo
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-06-15 17:06:39 PDT
Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy
Comment 1 Filip Pizlo 2013-06-15 17:08:15 PDT
Created attachment 204776 [details]
Patch
Comment 2 Sam Weinig 2013-06-15 18:43:09 PDT
Comment on attachment 204776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204776&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1554
> +#if ENABLE(JIT)
> +    , m_capabilityLevelState(DFG::CapabilityLevelNotSet)
> +#endif

Is this related?  If not, you should call it out in your changelog or commit it separately.
Comment 3 Filip Pizlo 2013-06-15 18:46:31 PDT
(In reply to comment #2)
> (From update of attachment 204776 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204776&action=review
> 
> > Source/JavaScriptCore/bytecode/CodeBlock.cpp:1554
> > +#if ENABLE(JIT)
> > +    , m_capabilityLevelState(DFG::CapabilityLevelNotSet)
> > +#endif
> 
> Is this related?  If not, you should call it out in your changelog or commit it separately.

No - while messing around with the constructor I realized that this field wasn't being initialized in all constructors.
Comment 4 Filip Pizlo 2013-06-15 18:49:54 PDT
Landed in http://trac.webkit.org/changeset/151618