Bug 117674 – Support using clang instead of gcc for bindings preprocessing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Darin Adler]

Support using clang instead of gcc for bindings preprocessing

[Darin Adler]

Created attachment 204771 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 204771 [details]
Patch

Clearing flags on attachment: 204771

Committed r151619: <http://trac.webkit.org/changeset/151619>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

The 'CC' environment variable should have been set to the correct compiler by the "Generate Derived Sources" build phase script (unless you were running the scripts outside of an Xcode build).

In the case of running the scripts outside of Xcode, the proper way to fix this for Mac OS X is to use 'xcrun' to find 'cc', which maps to the default compiler for the specified SDK (or the "current" SDK on Mac OS X) rather than to hard-code paths that assume the "CLTools" package is installed with Xcode (which isn't always true):

xcrun -find cc

[Mark Rowe (bdash)]

Yeah, I'm also surprised that the CC environment variable wasn't taking care of this.

[Darin Adler]

(In reply to comment #4)
> The 'CC' environment variable should have been set to the correct compiler by the "Generate Derived Sources" build phase script (unless you were running the scripts outside of an Xcode build).

I was. This is to make run-bindings-tests work. Sorry, I should have said that.

> In the case of running the scripts outside of Xcode, the proper way to fix this for Mac OS X is to use 'xcrun' to find 'cc', which maps to the default compiler for the specified SDK (or the "current" SDK on Mac OS X) rather than to hard-code paths that assume the "CLTools" package is installed with Xcode (which isn't always true):
> 
> xcrun -find cc

We could put a Mac-specific fix like that into these two perl scripts, or add Mac-specific code to run-bindings-tests so it sets CC. Do you have a preference, Dave?