Bug 117673 - Move Pasteboard::getStringSelection to Editor, fixing a layering violation
Summary: Move Pasteboard::getStringSelection to Editor, fixing a layering violation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-15 10:27 PDT by Darin Adler
Modified: 2013-06-15 19:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.58 KB, patch)
2013-06-15 10:35 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (7.58 KB, patch)
2013-06-15 11:03 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-06-15 10:27:48 PDT 
Move Pasteboard::getStringSelection to Editor, fixing a layering violation
Comment 1 Darin Adler 2013-06-15 10:35:15 PDT 
Created attachment 204770 [details]
Patch
Comment 2 Build Bot 2013-06-15 10:59:24 PDT 
Comment on attachment 204770 [details]
Patch

Attachment 204770 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/913116
Comment 3 Darin Adler 2013-06-15 11:03:03 PDT 
Created attachment 204772 [details]
Patch
Comment 4 Ryosuke Niwa 2013-06-15 11:18:13 PDT 
Comment on attachment 204772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204772&action=review

> Source/WebCore/editing/mac/EditorMac.mm:278
> +// FIXME: Makes no sense that selectedTextForClipboard always includes alt text, but stringSelectionForPasteboard does not.
> +// This was left in a bad state when selectedTextForClipboard was added. Need to look over clients and fix this.

There is some discussion in https://bugs.webkit.org/show_bug.cgi?id=11200 but the idea is that we don't want to include alt text when we're exposing it to Mac services.
I think the one that doesn't include alt should be postfixed with "ForClipboard".
Comment 5 WebKit Commit Bot 2013-06-15 19:21:41 PDT 
Comment on attachment 204772 [details]
Patch

Clearing flags on attachment: 204772

Committed r151620: <http://trac.webkit.org/changeset/151620>
Comment 6 WebKit Commit Bot 2013-06-15 19:21:44 PDT 
All reviewed patches have been landed.  Closing bug.