Bug 117671 - Initialize AtomicStringTable in WTFThreadData's constructor
Summary: Initialize AtomicStringTable in WTFThreadData's constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-14 22:44 PDT by Ryosuke Niwa
Modified: 2013-06-17 18:08 PDT (History)
14 users (show)

See Also:

Attachments
Cleanup (12.71 KB, patch)
2013-06-14 22:46 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed builds (15.78 KB, patch)
2013-06-14 23:14 PDT, Ryosuke Niwa 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-14 22:44:58 PDT 
Initialize AtomicStringTable in WTFThreadData's constructor
Comment 1 Ryosuke Niwa 2013-06-14 22:46:49 PDT 
Created attachment 204758 [details]
Cleanup
Comment 2 Ryosuke Niwa 2013-06-14 22:47:54 PDT 
This addresses a comment added to stringTable() in http://trac.webkit.org/changeset/57829.
Comment 3 EFL EWS Bot 2013-06-14 22:50:49 PDT 
Comment on attachment 204758 [details]
Cleanup

Attachment 204758 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/912040
Comment 4 Early Warning System Bot 2013-06-14 22:51:36 PDT 
Comment on attachment 204758 [details]
Cleanup

Attachment 204758 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/904099
Comment 5 Early Warning System Bot 2013-06-14 22:53:21 PDT 
Comment on attachment 204758 [details]
Cleanup

Attachment 204758 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/916055
Comment 6 kov's GTK+ EWS bot 2013-06-14 22:53:22 PDT 
Comment on attachment 204758 [details]
Cleanup

Attachment 204758 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/909053
Comment 7 EFL EWS Bot 2013-06-14 22:53:49 PDT 
Comment on attachment 204758 [details]
Cleanup

Attachment 204758 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/930052
Comment 8 Ryosuke Niwa 2013-06-14 23:14:35 PDT 
Created attachment 204760 [details]
Fixed builds
Comment 9 Darin Adler 2013-06-15 11:00:26 PDT 
Comment on attachment 204760 [details]
Fixed builds

Why is this a class? We should just have HashSet<StringImpl*> in the thread data. We can have create and destroy functions, but no need to have this be a class.
Comment 10 Ryosuke Niwa 2013-06-15 11:14:07 PDT 
(In reply to comment #9)
> (From update of attachment 204760 [details])
> Why is this a class? We should just have HashSet<StringImpl*> in the thread data. We can have create and destroy functions, but no need to have this be a class.

I think the idea is to add, remove, etc... to this class to eventually encapsulate m_table. IdentifierTable does this already: http://trac.webkit.org/browser/trunk/Source/WTF/wtf/WTFThreadData.h#L42
Comment 11 Geoffrey Garen 2013-06-17 13:53:40 PDT 
Comment on attachment 204760 [details]
Fixed builds

View in context: https://bugs.webkit.org/attachment.cgi?id=204760&action=review

r=me

> Source/WTF/ChangeLog:8
> +        Extracted AtomicStringTable from AtomicString.cpp into AtomicStringTable.h.cpp

.h.cpp :(.
Comment 12 Ryosuke Niwa 2013-06-17 18:08:47 PDT 
Committed r151663: <http://trac.webkit.org/changeset/151663>