Bug 117670 – Crash in supportsSnapshotting

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Dean Jackson]

We're seeing occasional crashes in PluginProxy::supportsSnapshotting.

Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread
0   com.apple.WebKit2             	0x1037f4ca3 WebKit::PluginProxy::supportsSnapshotting() const + 27 (/usr/local/include/wtf/RefPtr.h:64)
1   com.apple.WebKit2             	0x1037f9716 WebKit::PluginView::pluginSnapshotTimerFired(WebCore::DeferrableOneShotTimer<WebKit::PluginView>*) + 64 (/SourceCache/WebKit2/WebKit2-7537.43.2/WebProcess/Plugins/PluginView.cpp:1637)
2   com.apple.WebCore             	0x10401d70f WebCore::ThreadTimers::sharedTimerFiredInternal() + 175 (/SourceCache/WebCore/WebCore-7537.43.2/platform/ThreadTimers.cpp:129)
3   com.apple.WebCore             	0x10401d5e3 WebCore::timerFired(__CFRunLoopTimer*, void*) + 51 (/SourceCache/WebCore/WebCore-7537.43.2/platform/mac/SharedTimerMac.mm:137)

<rdar://problem/14059711>

[Dean Jackson]

Created attachment 204755 [details]
Patch

[Build Bot]

Comment on attachment 204755 [details]
Patch

Attachment 204755 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/864172

New failing tests:
fast/workers/worker-close-more.html

[Build Bot]

Created attachment 204764 [details]
Archive of layout-test-results from APPLE-EWS-1 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-1  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

[Dean Jackson]

Shame that the crash log wasn't included in the archive, but I'm pretty sure that has nothing to do with this patch. 

The code changed could only be triggered:

a. in a page with plugins
b. running WebKit2

fast/workers/worker-close-more.html has neither of those conditions.

[Dean Jackson]

Committed r151617: <http://trac.webkit.org/changeset/151617>