Bug 117670 - Crash in supportsSnapshotting
Summary: Crash in supportsSnapshotting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-14 19:41 PDT by Dean Jackson
Modified: 2013-06-15 15:56 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.17 KB, patch)
2013-06-14 20:59 PDT, Dean Jackson
darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-1 for win-future (782.27 KB, application/zip)
2013-06-15 03:18 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-06-14 19:41:33 PDT
We're seeing occasional crashes in PluginProxy::supportsSnapshotting.

Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread
0   com.apple.WebKit2             	0x1037f4ca3 WebKit::PluginProxy::supportsSnapshotting() const + 27 (/usr/local/include/wtf/RefPtr.h:64)
1   com.apple.WebKit2             	0x1037f9716 WebKit::PluginView::pluginSnapshotTimerFired(WebCore::DeferrableOneShotTimer<WebKit::PluginView>*) + 64 (/SourceCache/WebKit2/WebKit2-7537.43.2/WebProcess/Plugins/PluginView.cpp:1637)
2   com.apple.WebCore             	0x10401d70f WebCore::ThreadTimers::sharedTimerFiredInternal() + 175 (/SourceCache/WebCore/WebCore-7537.43.2/platform/ThreadTimers.cpp:129)
3   com.apple.WebCore             	0x10401d5e3 WebCore::timerFired(__CFRunLoopTimer*, void*) + 51 (/SourceCache/WebCore/WebCore-7537.43.2/platform/mac/SharedTimerMac.mm:137)

<rdar://problem/14059711>
Comment 1 Dean Jackson 2013-06-14 20:59:38 PDT
Created attachment 204755 [details]
Patch
Comment 2 Build Bot 2013-06-15 03:18:55 PDT
Comment on attachment 204755 [details]
Patch

Attachment 204755 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/864172

New failing tests:
fast/workers/worker-close-more.html
Comment 3 Build Bot 2013-06-15 03:18:56 PDT
Created attachment 204764 [details]
Archive of layout-test-results from APPLE-EWS-1 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-1  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 4 Dean Jackson 2013-06-15 09:14:53 PDT
Shame that the crash log wasn't included in the archive, but I'm pretty sure that has nothing to do with this patch. 

The code changed could only be triggered:

a. in a page with plugins
b. running WebKit2

fast/workers/worker-close-more.html has neither of those conditions.
Comment 5 Dean Jackson 2013-06-15 15:56:36 PDT
Committed r151617: <http://trac.webkit.org/changeset/151617>