Bug 117665 – Crash in loadPendingShaders

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dean Jackson]

We're getting many reports of a crash in loadPendingShaders. Alas, we don't have the content or URLs - it's an automated system.

Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x00007fff8c2f19d8 WebCore::StyleResolver::loadPendingShaders() + 24
1   com.apple.WebCore             	0x00007fff8c2e4f71 WebCore::StyleResolver::applyMatchedProperties(WebCore::StyleResolver::MatchResult const&, WebCore::Element const*) + 1089
2   com.apple.WebCore             	0x00007fff8c2e0a0c WebCore::StyleResolver::styleForElement(WebCore::Element*, WebCore::RenderStyle*, WebCore::StyleSharingBehavior, WebCore::RuleMatchingBehavior, WebCore::RenderRegion*) + 3404
3   com.apple.WebCore             	0x00007fff8bd4044a WebCore::Element::styleForRenderer() + 122
4   com.apple.WebCore             	0x00007fff8c1246c0 WebCore::NodeRenderingContext::createRendererForElementIfNeeded() + 48
5   com.apple.WebCore             	0x00007fff8b6b57e7 WebCore::Element::attach() + 55
6   com.apple.WebCore             	0x00007fff8bdc894c WebCore::executeTask(WebCore::HTMLConstructionSiteTask&) + 172
7   com.apple.WebCore             	0x00007fff8bdc886c WebCore::HTMLConstructionSite::executeQueuedTasks() + 108
8   com.apple.WebCore             	0x00007fff8b6b4d0a WebCore::HTMLTreeBuilder::constructTreeFromToken(WebCore::HTMLToken&) + 74
9   com.apple.WebCore             	0x00007fff8b69a700 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) + 352
10  com.apple.WebCore             	0x00007fff8b6fd2b3 WebCore::HTMLDocumentParser::append(WebCore::SegmentedString const&) + 243
11  com.apple.WebCore             	0x00007fff8bc493be WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter*, char const*, unsigned long) + 126
12  com.apple.WebCore             	0x00007fff8bc5f6f7 WebCore::DocumentLoader::commitData(char const*, unsigned long) + 327
13  com.apple.WebKit2             	0x00007fff87bdfd18 WebKit::WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) + 74
14  com.apple.WebCore             	0x00007fff8b6f88eb WebCore::DocumentLoader::commitLoad(char const*, int) + 139
15  com.apple.WebCore             	0x00007fff8c0efd11 WebCore::MainResourceLoader::dataReceived(WebCore::CachedResource*, char const*, int) + 657
16  com.apple.WebCore             	0x00007fff8bb842f3 WebCore::CachedRawResource::data(WTF::PassRefPtr<WebCore::ResourceBuffer>, bool) + 387
17  com.apple.WebCore             	0x00007fff8c30381b WebCore::SubresourceLoader::sendDataToResource(char const*, int) + 139
18  com.apple.WebCore             	0x00007fff8b733ebc WebCore::SubresourceLoader::didReceiveData(char const*, int, long long, bool) + 76

[Dean Jackson]

<rdar://problem/12936342>

[Alexandru Chiculita]

I will take a look on Monday.

[Max Vujovic]

Created attachment 204858 [details]
Patch

Speculative fix. My build isn't done yet, so hopefully this compiles :)

[Max Vujovic]

Comment on attachment 204858 [details]
Patch

My build looks good. Setting cq+.

[WebKit Commit Bot]

Comment on attachment 204858 [details]
Patch

Clearing flags on attachment: 204858

Committed r151657: <http://trac.webkit.org/changeset/151657>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.