Bug 117663 - [CSS Shapes] Consider bottom borders when calculating the position of the overflow
Summary: [CSS Shapes] Consider bottom borders when calculating the position of the ove...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 89256
  Show dependency treegraph
 
Reported: 2013-06-14 16:04 PDT by Zoltan Horvath
Modified: 2013-06-17 13:25 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (20.08 KB, patch)
2013-06-14 17:14 PDT, Zoltan Horvath
achicu: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-06-14 16:04:26 PDT
We need to push the overflow below the content box, not below the border box. The behavior was correct for flow thread cases, but not for simple cases. I refactored the overflow handling to a new helper function.
Comment 1 Zoltan Horvath 2013-06-14 17:14:21 PDT
Created attachment 204750 [details]
proposed patch
Comment 2 Alexandru Chiculita 2013-06-17 11:55:25 PDT
Comment on attachment 204750 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204750&action=review

Looks good.

> LayoutTests/ChangeLog:9
> +        not below the border box. The behavior was correct for flow thread cases, but not for not flow thread cases. I refactored

nit: "The behavior was correct for flow thread cases, but not for not flow thread cases." I'm not sure I follow this phrase :)

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1657
> +    if (lineOverFlowsFromShapeInside)

nit: Let's keep the Overflow with small caps, just to be consistent with the function name.
Comment 3 Zoltan Horvath 2013-06-17 13:25:43 PDT
(In reply to comment #2)

> nit: "The behavior was correct for flow thread cases, but not for not flow thread cases." I'm not sure I follow this phrase :)

Fixed.
 
> nit: Let's keep the Overflow with small caps, just to be consistent with the function name.

Fixed.

Thanks for the review.

Landed in: http://trac.webkit.org/changeset/151652