Bug 117663 – [CSS Shapes] Consider bottom borders when calculating the position of the overflow

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Zoltan Horvath]

We need to push the overflow below the content box, not below the border box. The behavior was correct for flow thread cases, but not for simple cases. I refactored the overflow handling to a new helper function.

[Zoltan Horvath]

Created attachment 204750 [details]
proposed patch

[Alexandru Chiculita]

Comment on attachment 204750 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204750&action=review

Looks good.

> LayoutTests/ChangeLog:9
> +        not below the border box. The behavior was correct for flow thread cases, but not for not flow thread cases. I refactored

nit: "The behavior was correct for flow thread cases, but not for not flow thread cases." I'm not sure I follow this phrase :)

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1657
> +    if (lineOverFlowsFromShapeInside)

nit: Let's keep the Overflow with small caps, just to be consistent with the function name.

[Zoltan Horvath]

(In reply to comment #2)

> nit: "The behavior was correct for flow thread cases, but not for not flow thread cases." I'm not sure I follow this phrase :)

Fixed.
 
> nit: Let's keep the Overflow with small caps, just to be consistent with the function name.

Fixed.

Thanks for the review.

Landed in: http://trac.webkit.org/changeset/151652