Bug 117649 – [GTK][WK2] adding subtitles (with toggle button) on html videos

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Danilo de Paula]

[GTK][WK2] adding subtitles (with toggle button) on html videos

[Danilo de Paula]

Created attachment 204728 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Danilo de Paula]

Created attachment 204729 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 204729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204729&action=review

Thanks for the patch.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1163
> +    settings->priv->preferences->setShouldDisplaySubtitles(TRUE);

It should be true, not TRUE. If we want to enable this unconditionally, this is not the place to do it. You should change the default value of the setting for the GTK platform in Shared/WebPreferencesStore.h

[Danilo de Paula]

Created attachment 204812 [details]
Patch

[Danilo de Paula]

Comment on attachment 204812 [details]
Patch

wrong file here...

[Build Bot]

Comment on attachment 204812 [details]
Patch

Attachment 204812 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/929029

New failing tests:
media/video-controls-captions-trackmenu-hide-on-click.html
fast/repaint/table-cell-collapsed-border-scroll.html
media/video-controls-captions-trackmenu-hide-on-click-outside.html

[Build Bot]

Created attachment 204820 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 204812 [details]
Patch

Attachment 204812 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/895141

New failing tests:
media/video-controls-captions-trackmenu-hide-on-click.html
fast/repaint/table-cell-collapsed-border-scroll.html
media/video-controls-captions-trackmenu-hide-on-click-outside.html

[Build Bot]

Created attachment 204822 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 204812 [details]
Patch

Attachment 204812 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/857391

New failing tests:
media/video-controls-captions-trackmenu-hide-on-click.html
media/video-controls-captions-trackmenu-hide-on-click-outside.html

[Build Bot]

Created attachment 204839 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Danilo de Paula]

Subtitles support on webkitgtk is being handled by https://bugs.webkit.org/show_bug.cgi?id=117008

*** This bug has been marked as a duplicate of bug 117008 ***