Bug 117636 - [GTK] Compilation problems - hb.h not found
Summary: [GTK] Compilation problems - hb.h not found
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 117641 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-06-14 05:25 PDT by Morten Stenshorne
Modified: 2013-06-14 07:54 PDT (History)
3 users (show)

See Also:

Attachments
config.log (85.49 KB, application/octet-stream)
2013-06-14 05:26 PDT, Morten Stenshorne 		no flags Details
Patch (1.16 KB, patch)
2013-06-14 07:37 PDT, Andres Gomez Garcia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Morten Stenshorne 2013-06-14 05:25:38 PDT 
This problem seems to have been introduced by the fix for bug 115936. config.log attached.

Here are the errors I get:

In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:32:0,
                 from ../../Source/WebCore/platform/graphics/FontPlatformData.h:33,
                 from ../../Source/WebCore/platform/graphics/SimpleFontData.h:30,
                 from ../../Source/WebCore/platform/graphics/FontGlyphs.h:25,
                 from ../../Source/WebCore/platform/graphics/Font.h:29,
                 from ../../Source/WebCore/platform/graphics/GraphicsContext.h:33,
                 from ../../Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:34:
../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory
compilation terminated.

In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:32:0,
                 from ../../Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:26:
../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory
compilation terminated.

In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:32:0,
                 from ../../Source/WebCore/platform/graphics/FontPlatformData.h:33,
                 from ../../Source/WebCore/platform/graphics/SimpleFontData.h:30,
                 from ../../Source/WebCore/platform/graphics/FontGlyphs.h:25,
                 from ../../Source/WebCore/platform/graphics/Font.h:29,
                 from ../../Source/WebCore/platform/PopupMenuStyle.h:30,
                 from ../../Source/WebCore/platform/PopupMenuClient.h:26,
                 from ../../Source/WebCore/platform/gtk/PopupMenuGtk.h:26,
                 from ../../Source/WebCore/platform/gtk/SearchPopupMenuGtk.h:24,
                 from ../../Source/WebCore/platform/gtk/SearchPopupMenuGtk.cpp:20:
../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory
compilation terminated.

In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:32:0,
                 from ../../Source/WebCore/platform/graphics/FontPlatformData.h:33,
                 from ../../Source/WebCore/platform/graphics/SimpleFontData.h:30,
                 from ../../Source/WebCore/platform/graphics/FontGlyphs.h:25,
                 from ../../Source/WebCore/platform/graphics/Font.h:29,
                 from ../../Source/WebCore/platform/graphics/GraphicsContext.h:33,
                 from ../../Source/WebCore/platform/gtk/WidgetGtk.cpp:32:
../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory
compilation terminated.

I'm currently on commit cf95a00dabac52ceed5488b4949431e0643c7178 "[Qt] Unreviewed TestExpectation cleanup".
Comment 1 Morten Stenshorne 2013-06-14 05:26:11 PDT 
Created attachment 204704 [details]
config.log
Comment 2 Andres Gomez Garcia 2013-06-14 07:31:51 PDT 
bug 117636 is a duplicate of this one with a patch proposal
Comment 3 Andres Gomez Garcia 2013-06-14 07:34:13 PDT 
*** Bug 117641 has been marked as a duplicate of this bug. ***
Comment 4 Andres Gomez Garcia 2013-06-14 07:37:51 PDT 
Created attachment 204712 [details]
Patch
Comment 5 WebKit Commit Bot 2013-06-14 07:54:02 PDT 
Comment on attachment 204712 [details]
Patch

Clearing flags on attachment: 204712

Committed r151594: <http://trac.webkit.org/changeset/151594>
Comment 6 WebKit Commit Bot 2013-06-14 07:54:04 PDT 
All reviewed patches have been landed.  Closing bug.