Bug 117636 – [GTK] Compilation problems - hb.h not found

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Morten Stenshorne]

This problem seems to have been introduced by the fix for bug 115936. config.log attached.

Here are the errors I get:

In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:32:0,
                 from ../../Source/WebCore/platform/graphics/FontPlatformData.h:33,
                 from ../../Source/WebCore/platform/graphics/SimpleFontData.h:30,
                 from ../../Source/WebCore/platform/graphics/FontGlyphs.h:25,
                 from ../../Source/WebCore/platform/graphics/Font.h:29,
                 from ../../Source/WebCore/platform/graphics/GraphicsContext.h:33,
                 from ../../Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:34:
../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory
compilation terminated.

In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:32:0,
                 from ../../Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:26:
../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory
compilation terminated.

In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:32:0,
                 from ../../Source/WebCore/platform/graphics/FontPlatformData.h:33,
                 from ../../Source/WebCore/platform/graphics/SimpleFontData.h:30,
                 from ../../Source/WebCore/platform/graphics/FontGlyphs.h:25,
                 from ../../Source/WebCore/platform/graphics/Font.h:29,
                 from ../../Source/WebCore/platform/PopupMenuStyle.h:30,
                 from ../../Source/WebCore/platform/PopupMenuClient.h:26,
                 from ../../Source/WebCore/platform/gtk/PopupMenuGtk.h:26,
                 from ../../Source/WebCore/platform/gtk/SearchPopupMenuGtk.h:24,
                 from ../../Source/WebCore/platform/gtk/SearchPopupMenuGtk.cpp:20:
../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory
compilation terminated.

In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:32:0,
                 from ../../Source/WebCore/platform/graphics/FontPlatformData.h:33,
                 from ../../Source/WebCore/platform/graphics/SimpleFontData.h:30,
                 from ../../Source/WebCore/platform/graphics/FontGlyphs.h:25,
                 from ../../Source/WebCore/platform/graphics/Font.h:29,
                 from ../../Source/WebCore/platform/graphics/GraphicsContext.h:33,
                 from ../../Source/WebCore/platform/gtk/WidgetGtk.cpp:32:
../../Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:34:16: fatal error: hb.h: No such file or directory
compilation terminated.

I'm currently on commit cf95a00dabac52ceed5488b4949431e0643c7178 "[Qt] Unreviewed TestExpectation cleanup".

[Morten Stenshorne]

Created attachment 204704 [details]
config.log

[Andres Gomez Garcia]

bug 117636 is a duplicate of this one with a patch proposal

[Andres Gomez Garcia]

*** Bug 117641 has been marked as a duplicate of this bug. ***

[Andres Gomez Garcia]

Created attachment 204712 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 204712 [details]
Patch

Clearing flags on attachment: 204712

Committed r151594: <http://trac.webkit.org/changeset/151594>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.