WebKitTestRunner will crash when WebProcess is not responsible.
Created attachment 204683 [details] Patch
Comment on attachment 204683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204683&action=review > Tools/WebKitTestRunner/TestController.cpp:757 > + TestInvocation::dumpWebProcessUnresponsiveness("<unknown> - TestController::run - Failed to reset state to consistent values\n"); Should this string have a newline in it?
Comment on attachment 204683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204683&action=review Thanks for the r+ >> Tools/WebKitTestRunner/TestController.cpp:757 >> + TestInvocation::dumpWebProcessUnresponsiveness("<unknown> - TestController::run - Failed to reset state to consistent values\n"); > > Should this string have a newline in it? Yes, the string will be passed to the TestInvocation::dump() through the argument 'textToStdout', and the tailing newline will separate the string and the '#EOF' string that the dump() function prints after the string. (All the stdout messages passed to the dump() function contains tailing newline with the current dump() implementation)
Comment on attachment 204683 [details] Patch Rejecting attachment 204683 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 204683, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/1014522
Created attachment 205914 [details] Patch Fix ChangeLog error
Comment on attachment 205914 [details] Patch Clearing flags on attachment: 205914 Committed r152295: <http://trac.webkit.org/changeset/152295>
All reviewed patches have been landed. Closing bug.