Bug 117629 – [GTK][WK1] Missing symbols

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Manuel Rego Casasnovas]

Compiling only WK1 like it's doing by the bots is not working due to missing symbols:
Tools/Scripts/build-webkit --release --gtk --no-webkit2

./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore41setJSTypeConversionsTestEnforceRangeOctetEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore7toUInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE'
./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore29setJSTypeConversionsTestOctetEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore7toUInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE'
./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore40setJSTypeConversionsTestEnforceRangeByteEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore6toInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE'
./.libs/libWebCoreInternals.a(./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSTypeConversions.o):JSTypeConversions.cpp:function _ZN7WebCore28setJSTypeConversionsTestByteEPN3JSC9ExecStateEPNS0_8JSObjectENS0_7JSValueE: error: undefined reference to '_ZN7WebCore6toInt8EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE'

[Manuel Rego Casasnovas]

(In reply to comment #0)
> Compiling only WK1 like it's doing by the bots is not working due to missing symbols:
> Tools/Scripts/build-webkit --release --gtk --no-webkit2

By bots I mean the GTK+ WK1 EWS.

[Manuel Rego Casasnovas]

Created attachment 204678 [details]
Patch

[Manuel Rego Casasnovas]

Created attachment 204679 [details]
Patch

WK1 build fails without this symbols while WK2 build works properly. As expxpected WK1 + WK2 build fails too.

[Carlos Garcia Campos]

Comment on attachment 204679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204679&action=review

> ChangeLog:9
> +        * Source/autotools/symbols.filter: Added missing symbols when compiling
> +        only WK1.

This comment is confusing, because this file is common for wk1 and wk2, I would say something like:

Added missing symbols *needed* when compiling WK1.

Removing also the "only" because they are also needed when building both wk1 and wk2.

[Manuel Rego Casasnovas]

Created attachment 204680 [details]
Patch

Fix ChangeLog message.

[WebKit Commit Bot]

Comment on attachment 204680 [details]
Patch

Clearing flags on attachment: 204680

Committed r151583: <http://trac.webkit.org/changeset/151583>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.