parseImageSet() can get m_valueList directly. And minor fixes.
Created attachment 204653 [details] Patch
Comment on attachment 204653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204653&action=review > Source/WebCore/css/CSSParser.cpp:8028 > + ASSERT(value->unit == CSSParserValue::Function && value->function); We never use && in an ASSERT. Instead use two separate assertions so you can see which failed. ASSERT(value->unit == CSSParserValue::Function); ASSERT(value->function); But also, I don’t think that ASSERT(value->function) is all that useful. We’ll see the null dereference right after this, it won’t be hard to debug. And there’s no reason to expect a null here. > Source/WebCore/css/CSSParser.cpp:8042 > RefPtr<CSSImageValue> image = CSSImageValue::create(completeURL(arg->string)); > - imageSet->append(image); > + imageSet->append(image.release()); Why use a local variable at all? I think this is better in a single line.
Comment on attachment 204653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204653&action=review Thanks for your review. >> Source/WebCore/css/CSSParser.cpp:8028 >> + ASSERT(value->unit == CSSParserValue::Function && value->function); > > We never use && in an ASSERT. Instead use two separate assertions so you can see which failed. > > ASSERT(value->unit == CSSParserValue::Function); > ASSERT(value->function); > > But also, I don’t think that ASSERT(value->function) is all that useful. We’ll see the null dereference right after this, it won’t be hard to debug. And there’s no reason to expect a null here. I'll remove 'value->function' >> Source/WebCore/css/CSSParser.cpp:8042 >> + imageSet->append(image.release()); > > Why use a local variable at all? I think this is better in a single line. I'll make it one line.
Created attachment 204664 [details] Patch
Comment on attachment 204664 [details] Patch Clearing flags on attachment: 204664 Committed r151597: <http://trac.webkit.org/changeset/151597>
All reviewed patches have been landed. Closing bug.