RESOLVED FIXED Bug 117607
[CSS Regions] Selection dragged from a region paints its background
https://bugs.webkit.org/show_bug.cgi?id=117607
Summary [CSS Regions] Selection dragged from a region paints its background
Max Vujovic
Reported 2013-06-13 13:11:08 PDT
Dragged selection should only draw its foreground. Patch with test case coming soon!
Attachments
Patch (3.96 KB, patch)
2013-06-13 13:49 PDT, Max Vujovic
achicu: review+
mvujovic: commit-queue-
Patch for Landing (3.91 KB, patch)
2013-06-13 14:21 PDT, Max Vujovic
no flags
Max Vujovic
Comment 1 2013-06-13 13:49:21 PDT
Alexandru Chiculita
Comment 2 2013-06-13 14:16:26 PDT
Comment on attachment 204639 [details] Patch Thanks Max. Looks good. It's sad it couldn't be an automatic test.
Max Vujovic
Comment 3 2013-06-13 14:21:58 PDT
Created attachment 204644 [details] Patch for Landing I noticed I had an extra margin CSS style in the test, which I've removed.
Max Vujovic
Comment 4 2013-06-13 14:23:56 PDT
(In reply to comment #2) > (From update of attachment 204639 [details]) > Thanks Max. Looks good. It's sad it couldn't be an automatic test. Thanks for the review, Alex. Yeah, it's too bad. I could only get a snapshot of the blue selection highlight, but not the dragged image using DRT.
Max Vujovic
Comment 5 2013-06-13 15:06:10 PDT
Comment on attachment 204644 [details] Patch for Landing Setting cq+.
WebKit Commit Bot
Comment 6 2013-06-13 15:33:01 PDT
Comment on attachment 204644 [details] Patch for Landing Clearing flags on attachment: 204644 Committed r151571: <http://trac.webkit.org/changeset/151571>
WebKit Commit Bot
Comment 7 2013-06-13 15:33:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.