Bug 117607 - [CSS Regions] Selection dragged from a region paints its background
Summary: [CSS Regions] Selection dragged from a region paints its background
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Vujovic
URL:
Keywords:
Depends on:
Blocks: 57312
  Show dependency tree / graph
 
Reported: 2013-06-13 13:11 PDT by Max Vujovic
Modified: 2013-06-13 15:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.96 KB, patch)
2013-06-13 13:49 PDT, Max Vujovic 		achicu: review+
mvujovic: commit-queue-
Details | Formatted Diff | Diff
Patch for Landing (3.91 KB, patch)
2013-06-13 14:21 PDT, Max Vujovic 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Vujovic 2013-06-13 13:11:08 PDT 
Dragged selection should only draw its foreground. Patch with test case coming soon!
Comment 1 Max Vujovic 2013-06-13 13:49:21 PDT 
Created attachment 204639 [details]
Patch
Comment 2 Alexandru Chiculita 2013-06-13 14:16:26 PDT 
Comment on attachment 204639 [details]
Patch

Thanks Max. Looks good. It's sad it couldn't be an automatic test.
Comment 3 Max Vujovic 2013-06-13 14:21:58 PDT 
Created attachment 204644 [details]
Patch for Landing

I noticed I had an extra margin CSS style in the test, which I've removed.
Comment 4 Max Vujovic 2013-06-13 14:23:56 PDT 
(In reply to comment #2)
> (From update of attachment 204639 [details])
> Thanks Max. Looks good. It's sad it couldn't be an automatic test.

Thanks for the review, Alex. Yeah, it's too bad. I could only get a snapshot of the blue selection highlight, but not the dragged image using DRT.
Comment 5 Max Vujovic 2013-06-13 15:06:10 PDT 
Comment on attachment 204644 [details]
Patch for Landing

Setting cq+.
Comment 6 WebKit Commit Bot 2013-06-13 15:33:01 PDT 
Comment on attachment 204644 [details]
Patch for Landing

Clearing flags on attachment: 204644

Committed r151571: <http://trac.webkit.org/changeset/151571>
Comment 7 WebKit Commit Bot 2013-06-13 15:33:03 PDT 
All reviewed patches have been landed.  Closing bug.