Bug 117597 - Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController.
Summary: Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks: 158729
  Show dependency tree / graph
 
Reported: 2013-06-13 09:09 PDT by Jer Noble
Modified: 2016-06-14 01:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.57 KB, patch)
2013-06-13 09:45 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-06-13 09:09:26 PDT 
Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController.
Comment 1 Jer Noble 2013-06-13 09:45:07 PDT 
Created attachment 204623 [details]
Patch
Comment 2 Eric Carlson 2013-06-13 10:38:24 PDT 
Comment on attachment 204623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204623&action=review

Nice rework!

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:102
> +- (void)setupVideoOverlay:(CALayer*)layer

Nit: you should have a space before the "*"

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:146
> +            QTMovie* movie = _mediaElement->platformMedia().media.qtMovie;
> +            QTMovieLayer* layer = [[getQTMovieLayerClass() alloc] init];

Nit: ObjC types get the "*" next to the variable name.

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:159
> +            AVPlayer* player = _mediaElement->platformMedia().media.avfMediaPlayer;
> +            AVPlayerLayer* layer = [[getAVPlayerLayerClass() alloc] init];

Ditto.

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:194
> +    CALayer* layer = [[[self window] contentView] layer];

Ditto.

> Source/WebCore/platform/mac/WebVideoFullscreenController.mm:433
>  // MARK: -
>  // MARK: QTMovie callbacks
>  

Nit: you might want to move this below rateChanged: since it is no longer QTKit-specific.
Comment 3 Jer Noble 2013-06-14 15:29:29 PDT 
Committed r151608: <http://trac.webkit.org/changeset/151608>