WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
117595
Refactor ObjCCallbackFunction to inherit directly from InternalFunction
https://bugs.webkit.org/show_bug.cgi?id=117595
Summary
Refactor ObjCCallbackFunction to inherit directly from InternalFunction
Mark Hahnenberg
Reported
2013-06-13 08:51:13 PDT
As part of
bug 117594
, we need to get ObjCCallbackFunction to inherit from InternalFunction rather than JSCallbackFunction.
Attachments
Patch
(15.65 KB, patch)
2013-06-13 09:03 PDT
,
Mark Hahnenberg
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2013-06-13 09:03:42 PDT
Created
attachment 204600
[details]
Patch
Geoffrey Garen
Comment 2
2013-06-13 10:30:32 PDT
Comment on
attachment 204600
[details]
Patch r=me
Geoffrey Garen
Comment 3
2013-06-13 10:31:06 PDT
At some point, we'll probably want to split the API folder in c and objc sub-folders. "API" is a slightly ambiguous prefix now.
Mark Hahnenberg
Comment 4
2013-06-13 12:17:07 PDT
(In reply to
comment #3
)
> At some point, we'll probably want to split the API folder in c and objc sub-folders. "API" is a slightly ambiguous prefix now.
That sounds like a good thing to do as part of my refactoring rampage. I picked APIFunctionCallback to indicate that it's a general struct used in both the C and Obj-C APIs.
Mark Hahnenberg
Comment 5
2013-06-19 13:09:58 PDT
Committed
r151749
: <
http://trac.webkit.org/changeset/151749
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug