Bug 117595 - Refactor ObjCCallbackFunction to inherit directly from InternalFunction
Summary: Refactor ObjCCallbackFunction to inherit directly from InternalFunction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 117594
  Show dependency tree / graph
 
Reported: 2013-06-13 08:51 PDT by Mark Hahnenberg
Modified: 2013-06-19 13:09 PDT (History)
1 user (show)

See Also:

Attachments
Patch (15.65 KB, patch)
2013-06-13 09:03 PDT, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-06-13 08:51:13 PDT 
As part of bug 117594, we need to get ObjCCallbackFunction to inherit from InternalFunction rather than JSCallbackFunction.
Comment 1 Mark Hahnenberg 2013-06-13 09:03:42 PDT 
Created attachment 204600 [details]
Patch
Comment 2 Geoffrey Garen 2013-06-13 10:30:32 PDT 
Comment on attachment 204600 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2013-06-13 10:31:06 PDT 
At some point, we'll probably want to split the API folder in c and objc sub-folders. "API" is a slightly ambiguous prefix now.
Comment 4 Mark Hahnenberg 2013-06-13 12:17:07 PDT 
(In reply to comment #3)
> At some point, we'll probably want to split the API folder in c and objc sub-folders. "API" is a slightly ambiguous prefix now.

That sounds like a good thing to do as part of my refactoring rampage. I picked APIFunctionCallback to indicate that it's a general struct used in both the C and Obj-C APIs.
Comment 5 Mark Hahnenberg 2013-06-19 13:09:58 PDT 
Committed r151749: <http://trac.webkit.org/changeset/151749>