Bug 117584 - [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
Summary: [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Pena
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2013-06-13 01:25 PDT by Zan Dobersek
Modified: 2013-08-29 02:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.56 KB, patch)
2013-08-16 03:44 PDT, Simon Pena 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-06-13 01:25:26 PDT 
The http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html layout test is failing on GTK WK1 since introduced in r151088.
http://trac.webkit.org/changeset/151088

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/loading/unfinished-load-back-to-cached-page-callbacks-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/loading/unfinished-load-back-to-cached-page-callbacks-actual.txt
@@ -6,7 +6,6 @@
 main frame - didStartProvisionalLoadForFrame
 main frame - didCommitLoadForFrame
 main frame - didFinishDocumentLoadForFrame
-main frame - didFailLoadWithError
 main frame - didStartProvisionalLoadForFrame
 main frame - didCommitLoadForFrame
 main frame - didFinishLoadForFrame
Comment 1 Simon Pena 2013-08-15 05:58:49 PDT 
Also

http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html

This new test was added in r153649 <http://trac.webkit.org/changeset/153649>, copied from

http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html
Comment 2 Simon Pena 2013-08-16 03:44:17 PDT 
Created attachment 208905 [details]
Patch

This patch makes the two tests pass, but requires to rebaseline a third one (into a mix between mac and EFL ports). The other option would be to rebase these two tests so in GTK we don't expect them to print didFailLoadWithError
Comment 3 Simon Pena 2013-08-29 02:30:06 PDT 
This landed in r154318 <http://trac.webkit.org/changeset/154318>, with the "Reviewed By" line being fixed in r154319 <http://trac.webkit.org/changeset/154319>.