Bug 117578 - Avoid unwanted thread hops in ScriptProcessorNode when 'onaudioprocess' listener is not set
Summary: Avoid unwanted thread hops in ScriptProcessorNode when 'onaudioprocess' liste...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-12 23:39 PDT by Praveen Jadhav
Modified: 2013-06-13 10:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.82 KB, patch)
2013-06-12 23:53 PDT, Praveen Jadhav
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Praveen Jadhav 2013-06-12 23:39:28 PDT
In current WebKit code, callOnMainThread() is called always even though 'onaudioprocess' listener is not set in ScriptProcessorNode.
Comment 1 Praveen Jadhav 2013-06-12 23:53:06 PDT
Created attachment 204557 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-13 10:03:31 PDT
Comment on attachment 204557 [details]
Patch

Clearing flags on attachment: 204557

Committed r151558: <http://trac.webkit.org/changeset/151558>
Comment 3 WebKit Commit Bot 2013-06-13 10:03:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Chris Rogers 2013-06-13 10:21:13 PDT
Comment on attachment 204557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204557&action=review

> Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:145
> +        return;

you need to call zero() on outputBus before returning to make sure you're producing silence