Bug 117566 - [CSS Regions] -webkit-background-clip: text; does not clip the background in regions
Summary: [CSS Regions] -webkit-background-clip: text; does not clip the background in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Vujovic
URL:
Keywords:
Depends on:
Blocks: 57312
  Show dependency treegraph
 
Reported: 2013-06-12 15:53 PDT by Max Vujovic
Modified: 2013-06-13 09:50 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.23 KB, patch)
2013-06-12 16:20 PDT, Max Vujovic
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (1.40 MB, application/zip)
2013-06-13 02:01 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Max Vujovic 2013-06-12 15:53:50 PDT
Patch with test case coming up!
Comment 1 Max Vujovic 2013-06-12 16:20:36 PDT
Created attachment 204544 [details]
Patch
Comment 2 Alexandru Chiculita 2013-06-12 16:27:23 PDT
Comment on attachment 204544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204544&action=review

r=me

> Source/WebCore/rendering/RenderFlowThread.cpp:306
> +        PaintBehavior paintBehavior = 0;

nit: I know that you are going to do selection phase, too. Usually we would have written this in one single line using the ?: operator.
Comment 3 Build Bot 2013-06-13 02:01:04 PDT
Comment on attachment 204544 [details]
Patch

Attachment 204544 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/847086

New failing tests:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html
Comment 4 Build Bot 2013-06-13 02:01:06 PDT
Created attachment 204562 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 5 Max Vujovic 2013-06-13 09:34:22 PDT
(In reply to comment #3)
> (From update of attachment 204544 [details])
> Attachment 204544 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/847086
> 
> New failing tests:
> http/tests/security/cross-origin-plugin-private-browsing-toggled.html

This failure looks unrelated and doesn't repro locally.
Comment 6 Max Vujovic 2013-06-13 09:35:25 PDT
Comment on attachment 204544 [details]
Patch

Setting cq+.
Comment 7 Max Vujovic 2013-06-13 09:36:22 PDT
(In reply to comment #2)
> (From update of attachment 204544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204544&action=review
> 
> r=me
> 
> > Source/WebCore/rendering/RenderFlowThread.cpp:306
> > +        PaintBehavior paintBehavior = 0;
> 
> nit: I know that you are going to do selection phase, too. Usually we would have written this in one single line using the ?: operator.

Yup, I'm working on the selection phase patch right now :)
Comment 8 WebKit Commit Bot 2013-06-13 09:50:53 PDT
Comment on attachment 204544 [details]
Patch

Clearing flags on attachment: 204544

Committed r151555: <http://trac.webkit.org/changeset/151555>
Comment 9 WebKit Commit Bot 2013-06-13 09:50:55 PDT
All reviewed patches have been landed.  Closing bug.