Bug 117564 - [GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used.
Summary: [GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hugo Parente Lima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-12 15:32 PDT by Hugo Parente Lima
Modified: 2013-06-12 16:53 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2013-06-12 15:34 PDT, Hugo Parente Lima 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hugo Parente Lima 2013-06-12 15:32:15 PDT 
This compilation problem happen if you try to use libcurl as network backend because glib.h isn't included by libcurl headers.

I know the official and only one supported network backend for GTK port is libSoup, anyway it's a error to not directly include the glib header where using their types besides this help whom are doing tests with libcurl :-)
Comment 1 Hugo Parente Lima 2013-06-12 15:34:23 PDT 
Created attachment 204539 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-12 16:53:13 PDT 
Comment on attachment 204539 [details]
Patch

Clearing flags on attachment: 204539

Committed r151527: <http://trac.webkit.org/changeset/151527>
Comment 3 WebKit Commit Bot 2013-06-12 16:53:15 PDT 
All reviewed patches have been landed.  Closing bug.