Bug 117562 - Headers and footers should be pinned to the left edge of the window when scrolling horizontally, even when zoomed
Summary: Headers and footers should be pinned to the left edge of the window when scro...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
Keywords: InRadar
Depends on:
Reported: 2013-06-12 14:50 PDT by Beth Dakin
Modified: 2013-06-13 11:23 PDT (History)
9 users (show)

See Also:

Patch (2.38 KB, patch)
2013-06-12 15:40 PDT, Beth Dakin
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-06-12 14:50:27 PDT
http://trac.webkit.org/changeset/150043 made headers and footers stay pinned to the left edge when scrolling horizontally, but the bug still occurs when you are scrolled horizontally and zoomed in. Patch forthcoming. 

Comment 1 Beth Dakin 2013-06-12 15:40:43 PDT
Created attachment 204540 [details]
Comment 2 Sam Weinig 2013-06-13 11:09:10 PDT
Comment on attachment 204540 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=204540&action=review

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:321
> +    float horizontalScrollOffsetForBanner = scrollOffsetForFixedChildren.width();
> +    if (frameScaleFactor() != 1)
> +        horizontalScrollOffsetForBanner = FrameView::scrollOffsetForFixedPosition(viewportRect(), totalContentsSize(), position, scrollOrigin(), 1, false, headerHeight(), footerHeight()).width();
> +

This could use a comment.  It is confusing enough.
Comment 3 Beth Dakin 2013-06-13 11:23:04 PDT
Comment added! Thank you! http://trac.webkit.org/changeset/151564