Bug 117559 - fourthTier: DFG should support op_switch_imm
Summary: fourthTier: DFG should support op_switch_imm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-12 12:53 PDT by Filip Pizlo
Modified: 2013-06-15 15:37 PDT (History)
7 users (show)

See Also:

Attachments
work in progress (28.87 KB, patch)
2013-06-12 12:57 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (42.88 KB, patch)
2013-06-13 11:29 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (43.29 KB, patch)
2013-06-13 11:32 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (46.76 KB, patch)
2013-06-13 13:56 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-06-12 12:53:52 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-06-12 12:57:15 PDT 
Created attachment 204501 [details]
work in progress

I still have more gluing to do before it works, but it's getting there.
Comment 2 Filip Pizlo 2013-06-13 11:29:56 PDT 
Created attachment 204631 [details]
the patch
Comment 3 Filip Pizlo 2013-06-13 11:32:47 PDT 
Created attachment 204634 [details]
the patch

Added more to the changelog.
Comment 4 Filip Pizlo 2013-06-13 11:34:35 PDT 
Comment on attachment 204634 [details]
the patch

Ha!  Forgot all about 32-bit.
Comment 5 Filip Pizlo 2013-06-13 13:56:35 PDT 
Created attachment 204640 [details]
the patch

For real this time.
Comment 6 Michael Saboff 2013-06-13 15:02:15 PDT 
Comment on attachment 204640 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204640&action=review

How hard would it be to put the edge code removal in a separate patch?

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2719
> +            

nit - delete the white space
Comment 7 Filip Pizlo 2013-06-13 15:47:17 PDT 
(In reply to comment #6)
> (From update of attachment 204640 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204640&action=review
> 
> How hard would it be to put the edge code removal in a separate patch?
> 
> > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2719
> > +            
> 
> nit - delete the white space

Done!
Comment 8 Filip Pizlo 2013-06-15 15:37:31 PDT 
Landed in http://trac.webkit.org/changeset/151616