Bug 117546 - [GTK] Remove comment about possibility of handling ObjCPolymorphic (it's used by ObjC bindings only)
Summary: [GTK] Remove comment about possibility of handling ObjCPolymorphic (it's used...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-12 08:06 PDT by Diego Pino
Modified: 2013-06-18 06:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2013-06-12 08:11 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2013-06-17 10:13 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2013-06-12 08:06:15 PDT 
There is the following comment in CodeGeneratorGObject.pm:

# FIXME: should we use ObjCPolymorphic attribute? or is it specific to ObjC bindings?

According to WebKit WebIDL spec [1] ObjCPolymorphic only applies to the Objective-C bindings, so this comment is misleading.

[1] http://trac.webkit.org/wiki/WebKitIDL
Comment 1 Diego Pino 2013-06-12 08:11:23 PDT 
Created attachment 204443 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-17 09:45:00 PDT 
Comment on attachment 204443 [details]
Patch

Rejecting attachment 204443 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 204443, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/906404
Comment 3 Diego Pino 2013-06-17 10:13:05 PDT 
Created attachment 204834 [details]
Patch
Comment 4 WebKit Commit Bot 2013-06-18 06:05:16 PDT 
Comment on attachment 204834 [details]
Patch

Clearing flags on attachment: 204834

Committed r151682: <http://trac.webkit.org/changeset/151682>
Comment 5 WebKit Commit Bot 2013-06-18 06:05:19 PDT 
All reviewed patches have been landed.  Closing bug.