Bug 117541 - Fix crashes due to failed ImageBuffer allocation
Summary: Fix crashes due to failed ImageBuffer allocation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-06-12 07:09 PDT by Gyuyoung Kim
Modified: 2013-06-12 16:30 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2013-06-12 07:12 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2013-06-12 07:40 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-06-12 07:09:57 PDT 
A crash can happen due to a failed ImageBuffer allocation in SVGImage::drawPatternForContainer(). Added a check for that failed allocation.

Committed: https://src.chromium.org/viewvc/blink?revision=152268&view=revision
Comment 1 Gyuyoung Kim 2013-06-12 07:12:04 PDT 
Created attachment 204434 [details]
Patch
Comment 2 Chris Dumez 2013-06-12 07:22:44 PDT 
Comment on attachment 204434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204434&action=review

> Source/WebCore/ChangeLog:8
> +        From Blink r152268 by <wolenetz@chromium.org>

This Blink revision seems to be from Philip Rogers <pdr@chromium.org>?
Comment 3 Gyuyoung Kim 2013-06-12 07:40:50 PDT 
Created attachment 204438 [details]
Patch
Comment 4 Gyuyoung Kim 2013-06-12 07:41:28 PDT 
(In reply to comment #2)
> (From update of attachment 204434 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204434&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        From Blink r152268 by <wolenetz@chromium.org>
> 
> This Blink revision seems to be from Philip Rogers <pdr@chromium.org>?

Oops, my bad. Thanks.
Comment 5 WebKit Commit Bot 2013-06-12 16:30:21 PDT 
Comment on attachment 204438 [details]
Patch

Clearing flags on attachment: 204438

Committed r151525: <http://trac.webkit.org/changeset/151525>
Comment 6 WebKit Commit Bot 2013-06-12 16:30:24 PDT 
All reviewed patches have been landed.  Closing bug.