According to the specs: * http://www.w3.org/TR/DOM-Level-2-Core/core.html * http://www.w3.org/TR/DOM-Level-2-Style/css.html There are some parameters in some functions that can be NULL. However, the GObject DOM bindings don't accept NULL for these functions and parameters.
Created attachment 204432 [details] Patch
I also fixed the grep expression. It was wrong, it searched for any ocurrence of $paramName in all the array. In other words, if $paramName was a substring of some element of the array, it would have returned success (which is not true).
Comment on attachment 204432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204432&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:58 > 'webkit_dom_node_insert_before' => ['refChild'], I suppose the trailing comma is fine?
Comment on attachment 204432 [details] Patch Rejecting attachment 204432 [details] from commit-queue. dpino@igalia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Yes, in Perl is OK if the last element of an array has a comma
Comment on attachment 204432 [details] Patch Rejecting attachment 204432 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 204432, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/1165091
Comment on attachment 204432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204432&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). You need to remove this if you're not adding tests.
Created attachment 222211 [details] Patch
Comment on attachment 222211 [details] Patch Clearing flags on attachment: 222211 Committed r162766: <http://trac.webkit.org/changeset/162766>
All reviewed patches have been landed. Closing bug.