Bug 117536 - [GTK] Add parameters from 'DOM Object Model Core' spec and 'DOM CSS' spec that can be NULL
Summary: [GTK] Add parameters from 'DOM Object Model Core' spec and 'DOM CSS' spec tha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-12 04:38 PDT by Diego Pino
Modified: 2014-01-25 09:20 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.30 KB, patch)
2013-06-12 06:21 PDT, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (2.24 KB, patch)
2014-01-25 09:03 PST, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2013-06-12 04:38:09 PDT
According to the specs:

* http://www.w3.org/TR/DOM-Level-2-Core/core.html
* http://www.w3.org/TR/DOM-Level-2-Style/css.html

There are some parameters in some functions that can be NULL. However, the GObject DOM bindings don't accept NULL for these functions and parameters.
Comment 1 Diego Pino 2013-06-12 06:21:45 PDT
Created attachment 204432 [details]
Patch
Comment 2 Diego Pino 2013-06-12 06:25:14 PDT
I also fixed the grep expression. It was wrong, it searched for any ocurrence of $paramName in all the array. In other words, if $paramName was a substring of some element of the array, it would have returned success (which is not true).
Comment 3 Xan Lopez 2013-06-17 09:44:46 PDT
Comment on attachment 204432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204432&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:58
>      'webkit_dom_node_insert_before' => ['refChild'],

I suppose the trailing comma is fine?
Comment 4 WebKit Commit Bot 2013-07-22 11:07:04 PDT
Comment on attachment 204432 [details]
Patch

Rejecting attachment 204432 [details] from commit-queue.

dpino@igalia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 Diego Pino 2013-07-22 11:10:30 PDT
Yes, in Perl is OK if the last element of an array has a comma
Comment 6 WebKit Commit Bot 2013-07-23 00:56:16 PDT
Comment on attachment 204432 [details]
Patch

Rejecting attachment 204432 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 204432, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/1165091
Comment 7 Claudio Saavedra 2013-07-23 01:12:46 PDT
Comment on attachment 204432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204432&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

You need to remove this if you're not adding tests.
Comment 8 Diego Pino 2014-01-25 09:03:39 PST
Created attachment 222211 [details]
Patch
Comment 9 WebKit Commit Bot 2014-01-25 09:20:36 PST
Comment on attachment 222211 [details]
Patch

Clearing flags on attachment: 222211

Committed r162766: <http://trac.webkit.org/changeset/162766>
Comment 10 WebKit Commit Bot 2014-01-25 09:20:39 PST
All reviewed patches have been landed.  Closing bug.