Bug 117520 - remove existing CodeCoverage tool
Summary: remove existing CodeCoverage tool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh All
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-11 13:25 PDT by Alex Christensen
Modified: 2013-08-20 09:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (36.04 KB, patch)
2013-06-11 13:27 PDT, Alex Christensen
sam: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-06-11 13:25:46 PDT
The existing Tools/CodeCoverage directory contains code that doesn't work, hasn't been touched in 4-6 years, and needs improvements.  I'm working on a new code coverage/code heat tool that will replace this, but I suggest the old one be removed before adding the new one (which is still in the works).
Comment 1 Alex Christensen 2013-06-11 13:27:34 PDT
Created attachment 204355 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-11 14:16:31 PDT
Comment on attachment 204355 [details]
Patch

Rejecting attachment 204355 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 204355, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
m bug 117520.
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit

Did not find end of header block corresponding to index path "Tools/CodeCoverage/snow.png". at /Volumes/Data/EWS/WebKit/Tools/Scripts/VCSUtils.pm line 880, <ARGV> line 1033.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/738512
Comment 3 Alex Christensen 2013-06-11 14:24:25 PDT
I committed this manually.  r151472
Comment 4 Alex Christensen 2013-08-20 09:03:45 PDT
r151474