RESOLVED FIXED117514
Too many XcodeCoverageSupportOptions 
https://bugs.webkit.org/show_bug.cgi?id=117514
Summary Too many XcodeCoverageSupportOptions
Alex Christensen
Reported 2013-06-11 11:06:13 PDT
build-webkit --coverage and build-jsc --coverage fail because there are too many coverage support options that do not seem to have been updated in a few years. The only ones that are necessary to generate coverage code are GCC_GENERATE_TEST_COVERAGE_FILES=YES and GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES. Xcode takes care of the rest. #ifdef COVERAGE does not appear in the code. I'm not sure what the -MD flag does, but it causes webkit to not compile.
Attachments
Patch (1.33 KB, patch)
2013-06-11 11:10 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-06-11 11:10:18 PDT
Created attachment 204345 [details] Patch
WebKit Commit Bot
Comment 2 2013-06-11 13:02:10 PDT
Comment on attachment 204345 [details] Patch Clearing flags on attachment: 204345 Committed r151461: <http://trac.webkit.org/changeset/151461>
WebKit Commit Bot
Comment 3 2013-06-11 13:02:13 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2013-06-12 00:30:59 PDT
> I'm not sure what the -MD flag does Looks like a gcc option, ----------------- -MD is equivalent to -M -MF file, except that -E is not implied. The driver determines file based on whether an -o option is given. If it is, the driver uses its argument but with a suffix of .d, otherwise it take the basename of the input file and applies a .d suffix. If -MD is used in conjunction with -E, any -o switch is understood to specify the dependency output file (but see -MF), but if used without -E, each -o is understood to specify a target object file. Since -E is not implied, -MD can be used to generate a dependency output file as a side-effect of the compilation process. -----------------
Note You need to log in before you can comment on or make changes to this bug.