Bug 117507 – Support latest Web IDL indexed property getters

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

We should support the latest Web IDL indexed property getters and stop using the outdated [IndexedGetter] IDL extended attribute.

This is already supported by Blink in:
https://chromiumcodereview.appspot.com/14751005

[Chris Dumez]

Created attachment 204337 [details]
WIP Patch

[Chris Dumez]

Created attachment 204430 [details]
Patch

[Chris Dumez]

Created attachment 204431 [details]
Patch

Rebase on master.

[Kentaro Hara]

Comment on attachment 204430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204430&action=review

> Source/WebCore/bindings/scripts/CodeGenerator.pm:52
> +                       "octet" => 1);

I think "byte" and "octet" are supported neither CodeGeneratorJS.pm nor CodeGeneratorV8.pm. We might want to support them. (I think DataView's methods are written in custom bindings because of lack of support of "byte" and "octet".)

> Source/WebCore/html/RadioNodeList.idl:32
> +    getter Node ([IsIndex,Default=Undefined] optional unsigned long index);

Not related to this patch, I wonder why we need [IsIndex] in some getters and don't need it in other getters.

[Kentaro Hara]

(In reply to comment #4)
> (From update of attachment 204430 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204430&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGenerator.pm:52
> > +                       "octet" => 1);
> 
> I think "byte" and "octet" are supported neither CodeGeneratorJS.pm nor CodeGeneratorV8.pm. We might want to support them. (I think DataView's methods are written in custom bindings because of lack of support of "byte" and "octet".)

Of course, in a follow-up patch.

[Chris Dumez]

Comment on attachment 204430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204430&action=review

>> Source/WebCore/bindings/scripts/CodeGenerator.pm:52
>> +                       "octet" => 1);
> 
> I think "byte" and "octet" are supported neither CodeGeneratorJS.pm nor CodeGeneratorV8.pm. We might want to support them. (I think DataView's methods are written in custom bindings because of lack of support of "byte" and "octet".)

Yes, I know. Better support will be needed later on. For now, this makes sure that numeric indexed getters are properly detected in the canvas typed arrays since I use those types now.

>> Source/WebCore/html/RadioNodeList.idl:32
>> +    getter Node ([IsIndex,Default=Undefined] optional unsigned long index);
> 
> Not related to this patch, I wonder why we need [IsIndex] in some getters and don't need it in other getters.

I was wondering the same. The only difference is that an INDEX_SIZE_ERR exception will be thrown if index < 0. I was thinking that maybe some specs specify this behavior while other do not? Just speculation, I am really not sure what the real reason is yet. However, it is important that such refactoring patch does not change the behavior.

[WebKit Commit Bot]

Comment on attachment 204431 [details]
Patch

Clearing flags on attachment: 204431

Committed r151499: <http://trac.webkit.org/changeset/151499>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.