Bug 117491 – Consider using element rect instead of selection rect to compute the center of an element to reduce code size

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Accessibility

[Ryosuke Niwa]

We might want to merge https://chromium.googlesource.com/chromium/blink/+/a1fc9809d682deb494818a977cd480872f17f94e

Remove unused blink accessibility code.

The only functional change is to clickPoint, where we're now returning
the center of the element rect rather than the selection rect. There's
no difference 99% of the time. If that 1% is needed, we could rewrite
that logic in far less code.

Everything else was literally unused. Much is already implemented in
Chromium's browser process; the rest couldn't be used without refactoring
anyway.


Chris, any opinion on this?

[chris fleizach]

They're pulling out a lot of the code that Mac Accessibility uses to provide a complete API implementation. The comment says that they have implementations of this code in the browser side. 

Also the clickPoint change breaks the ability to bring up the context menu on the selected text range (I think, that code is a few years old)

So we should't take this change

[Ryosuke Niwa]

(In reply to comment #1)
> They're pulling out a lot of the code that Mac Accessibility uses to provide a complete API implementation. The comment says that they have implementations of this code in the browser side. 
> 
> Also the clickPoint change breaks the ability to bring up the context menu on the selected text range (I think, that code is a few years old)
> 
> So we should't take this change

Thanks!