RESOLVED FIXED 117486
Split SelectorDataList::executeSingleTagNameSelectorData() into the 4 kinds of traversal 
https://bugs.webkit.org/show_bug.cgi?id=117486
Summary Split SelectorDataList::executeSingleTagNameSelectorData() into the 4 kinds o...
Benjamin Poulain
Reported 2013-06-10 21:35:23 PDT
Split SelectorDataList::executeSingleTagNameSelectorData() into the 4 kinds of traversal
Attachments
Patch (3.85 KB, patch)
2013-06-10 22:07 PDT, Benjamin Poulain 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-06-10 22:07:30 PDT
Created attachment 204285 [details] Patch
Ryosuke Niwa
Comment 2 2013-06-10 23:40:37 PDT
Comment on attachment 204285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204285&action=review r=me provided the following comments are addressed. > Source/WebCore/dom/SelectorQuery.cpp:161 > + if (element->localName() == localName) { Can we assert that this condition matches with SelectorChecker::tagMatches(element, tagQualifiedName)? I'm afraid that this might get out of sync with SelectorChecker::tagMatches some day. > Source/WebCore/dom/SelectorQuery.cpp:173 > + matchedElements.append(element); Ditto.
Benjamin Poulain
Comment 3 2013-06-11 13:53:08 PDT
That's a very good point. I add a test verifying the generated matchedElements vector is correct.
Benjamin Poulain
Comment 4 2013-06-11 14:10:08 PDT
Committed r151470: <http://trac.webkit.org/changeset/151470>
Note You need to log in before you can comment on or make changes to this bug.