Bug 117484 – Simplify AccessibilityText

• Status: ASSIGNED
• Component: Accessibility

[Ryosuke Niwa]

Consider merging https://chromium.googlesource.com/chromium/blink/+/b76d6a339c94502c25b74dbfb5516cf20b522c07

The AccessibilityText struct had a vector of node references, when
a single reference is suffices since AccessibilityText itself is repeated.

This removes a ton of code from every function that uses AccessibilityText.

[chris fleizach]

I think this change breaks
ariaLabeledByText() because they're appending a new text object for each element instead of concatenating them like they need to be.

however, i don't know if the elements are even necessary. i don't see them being re-used. I think we could just allow  a pointer to an element because there's probably not a great reason to reference the elements after the string is made

however, i think we might also have bugs that ask us to actually return the elements in aria-labeledby so the screen reader can query those elements

[chris fleizach]

We should look into this to evaluate

[Radar WebKit Bug Importer]

<rdar://problem/16014103>

[Abu Naser Saifullah]

Created attachment 281135 [details]
http://www.bugs.webkit.org

[chris fleizach]

Comment on attachment 281135 [details]
http://www.bugs.webkit.org

Don't know what this is.. Spam?

[Ahmad Saleem]

I think it has been simplified but it is still using Vector rather than RefPtr:

https://github.com/WebKit/WebKit/blob/61b68425a2b484f2680d340ca998c38395d8d5fd/Source/WebCore/accessibility/AccessibilityNodeObject.cpp#L1839

Plus this commit removed "textElement" bits:

https://github.com/WebKit/WebKit/commit/f8283a7eece23958929380c652cebb7e7d302244

Is this needed anymore? Thanks!