NEW 117483
Avoid DEFINE_STATIC_LOCAL for strings in accessibility code 
https://bugs.webkit.org/show_bug.cgi?id=117483
Summary Avoid DEFINE_STATIC_LOCAL for strings in accessibility code
Ryosuke Niwa
Reported 2013-06-10 21:17:20 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/873a4a1f950d7cd7ebe27baba2c0e7e9491190f4 This pattern saved memory allocation at the expense of bloating code size. Prefer small code size when these aren't bottlenecks. Saves 72 bytes per string, for a total of 2448 bytes for this change. We might want to look for the same code elsewhere in WebCore.
Attachments
Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 3 2013-06-10 23:58:53 PDT
Do we prefer size over speed or vice versa Ryosuke?
Ryosuke Niwa
Comment 4 2013-06-11 01:14:56 PDT
(In reply to comment #3) > Do we prefer size over speed or vice versa Ryosuke? That's a good question. I think the argument here is that this code isn't performance critical.
Radar WebKit Bug Importer
Comment 5 2014-02-07 11:33:43 PST
<rdar://problem/16014102>
Benjamin Poulain
Comment 6 2014-02-07 15:49:48 PST
(In reply to comment #3) > Do we prefer size over speed or vice versa Ryosuke? Static also have overhead. I doubt these are justified by speed.
Note You need to log in before you can comment on or make changes to this bug.