Bug 117483 - Avoid DEFINE_STATIC_LOCAL for strings in accessibility code
Summary: Avoid DEFINE_STATIC_LOCAL for strings in accessibility code
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate, InRadar
Depends on:
Blocks:
 
Reported: 2013-06-10 21:17 PDT by Ryosuke Niwa
Modified: 2014-02-07 15:49 PST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-10 21:17:20 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/873a4a1f950d7cd7ebe27baba2c0e7e9491190f4

This pattern saved memory allocation at the expense of bloating
code size. Prefer small code size when these aren't bottlenecks.

Saves 72 bytes per string, for a total of 2448 bytes for this change.

We might want to look for the same code elsewhere in WebCore.
Comment 3 chris fleizach 2013-06-10 23:58:53 PDT 
Do we prefer size over speed or vice versa Ryosuke?
Comment 4 Ryosuke Niwa 2013-06-11 01:14:56 PDT 
(In reply to comment #3)
> Do we prefer size over speed or vice versa Ryosuke?

That's a good question. I think the argument here is that this code isn't performance critical.
Comment 5 Radar WebKit Bug Importer 2014-02-07 11:33:43 PST 
<rdar://problem/16014102>
Comment 6 Benjamin Poulain 2014-02-07 15:49:48 PST 
(In reply to comment #3)
> Do we prefer size over speed or vice versa Ryosuke?

Static also have overhead. I doubt these are justified by speed.