RESOLVED FIXED 117467
[EFL][WK2] Add ewk_view_navigate API 
https://bugs.webkit.org/show_bug.cgi?id=117467
Summary [EFL][WK2] Add ewk_view_navigate API
Ryuan Choi
Reported 2013-06-10 18:58:38 PDT
Patch will be added.
Attachments
Patch (5.05 KB, patch)
2013-06-10 19:10 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (5.04 KB, patch)
2013-06-11 00:05 PDT, Ryuan Choi 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2013-06-10 19:10:12 PDT
Created attachment 204276 [details] Patch
Chris Dumez
Comment 2 2013-06-10 22:59:19 PDT
Comment on attachment 204276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204276&action=review > Source/WebKit2/ChangeLog:11 > + (EwkBackForwardListItem::wkItem): Return WKBackForwardListItemRef for pate to navigate. pate -> page > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:314 > +Eina_Bool ewk_view_navigate(Evas_Object* ewkView, int steps) The application usually wants to navigate to a history item (i.e. back forward list item), not using a number of steps. I think this API should take a Ewk_Back_Forward_List_Item in argument and maybe rename to "ewk_view_navigate_to()".
Ryuan Choi
Comment 3 2013-06-10 23:20:58 PDT
(In reply to comment #2) > (From update of attachment 204276 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204276&action=review > > > Source/WebKit2/ChangeLog:11 > > + (EwkBackForwardListItem::wkItem): Return WKBackForwardListItemRef for pate to navigate. > > pate -> page > Oops, sorry I will fix it. > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:314 > > +Eina_Bool ewk_view_navigate(Evas_Object* ewkView, int steps) > > The application usually wants to navigate to a history item (i.e. back forward list item), not using a number of steps. I think this API should take a Ewk_Back_Forward_List_Item in argument and maybe rename to "ewk_view_navigate_to()". It depends on application developers but make sense. I choosed steps because I still consider consistency of legacy(ewebkit1 and elm_web). I will update like you mentioned.
Ryuan Choi
Comment 4 2013-06-11 00:05:36 PDT
Created attachment 204293 [details] Patch
Chris Dumez
Comment 5 2013-06-11 00:44:57 PDT
Comment on attachment 204293 [details] Patch Looks fine, r=me.
Ryuan Choi
Comment 6 2013-06-11 01:10:48 PDT
Committed r151427: <http://trac.webkit.org/changeset/151427>
Note You need to log in before you can comment on or make changes to this bug.