Bug 117435 - Add support for WaveShaperNode.oversample
Summary: Add support for WaveShaperNode.oversample
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-10 16:06 PDT by Chris Rogers
Modified: 2013-07-15 21:54 PDT (History)
12 users (show)

See Also:


Attachments
Patch (52.26 KB, patch)
2013-06-10 16:11 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (52.52 KB, patch)
2013-06-10 17:35 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (52.25 KB, patch)
2013-07-15 13:35 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2013-06-10 16:06:06 PDT
Add support for WaveShaperNode.oversample
Comment 1 Chris Rogers 2013-06-10 16:11:48 PDT
Created attachment 204222 [details]
Patch
Comment 2 Chris Rogers 2013-06-10 17:35:58 PDT
Created attachment 204233 [details]
Patch
Comment 3 Build Bot 2013-06-10 17:51:53 PDT
Comment on attachment 204233 [details]
Patch

Attachment 204233 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/793217
Comment 4 Build Bot 2013-06-10 20:26:47 PDT
Comment on attachment 204233 [details]
Patch

Attachment 204233 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/659606
Comment 5 Chris Rogers 2013-07-15 13:35:32 PDT
Created attachment 206681 [details]
Patch
Comment 6 Kenneth Russell 2013-07-15 15:02:08 PDT
Comment on attachment 206681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206681&action=review

r=me based on previous review and comparing to the earlier CL.

> Source/WebCore/platform/audio/DownSampler.cpp:44
> +    , m_inputBuffer(inputBlockSize * 2)

I noticed the initialization order differs from Blink's (and Blink's is likely wrong, not having the same warnings enabled as errors as WebKit). Do you plan to fix Blink's code?

> Source/WebCore/platform/audio/UpSampler.cpp:44
> +    , m_inputBuffer(inputBlockSize * 2)

Same comment about initialization order.
Comment 7 WebKit Commit Bot 2013-07-15 21:54:46 PDT
Comment on attachment 206681 [details]
Patch

Clearing flags on attachment: 206681

Committed r152702: <http://trac.webkit.org/changeset/152702>
Comment 8 WebKit Commit Bot 2013-07-15 21:54:50 PDT
All reviewed patches have been landed.  Closing bug.