Bug 117413 – [CoordinatedGraphics] Typos in custom shader support

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Ralph T]

CoordinatedLayerTreeHost.cpp:333 is

for (size_t j = 0; j < keyframes.size(); ++j) {
    const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(i));

but it should be:

for (size_t j = 0; j < keyframes.size(); ++j) {
    const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(j));


Also, WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:730 has the same bug, it is:

for (size_t j = 0; j < keyframes.size(); ++j) {
    const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(i));

but should be:

for (size_t j = 0; j < keyframes.size(); ++j) {
    const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(j));

I'm not set up for submitting patches currently, but I'll try to get setup soon (in the meantime, if anyone else wants to submit  something for this then that would be wonderful ;) ).

[Jae Hyun Park]

Created attachment 204271 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 204271 [details]
Patch

Clearing flags on attachment: 204271

Committed r151423: <http://trac.webkit.org/changeset/151423>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.