Bug 117413 - [CoordinatedGraphics] Typos in custom shader support
Summary: [CoordinatedGraphics] Typos in custom shader support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-10 10:09 PDT by Ralph T
Modified: 2013-06-10 22:47 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.57 KB, patch)
2013-06-10 18:09 PDT, Jae Hyun Park
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph T 2013-06-10 10:09:50 PDT
CoordinatedLayerTreeHost.cpp:333 is

for (size_t j = 0; j < keyframes.size(); ++j) {
    const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(i));

but it should be:

for (size_t j = 0; j < keyframes.size(); ++j) {
    const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(j));


Also, WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:730 has the same bug, it is:

for (size_t j = 0; j < keyframes.size(); ++j) {
    const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(i));

but should be:

for (size_t j = 0; j < keyframes.size(); ++j) {
    const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(j));

I'm not set up for submitting patches currently, but I'll try to get setup soon (in the meantime, if anyone else wants to submit  something for this then that would be wonderful ;) ).
Comment 1 Jae Hyun Park 2013-06-10 18:09:03 PDT
Created attachment 204271 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-10 22:47:47 PDT
Comment on attachment 204271 [details]
Patch

Clearing flags on attachment: 204271

Committed r151423: <http://trac.webkit.org/changeset/151423>
Comment 3 WebKit Commit Bot 2013-06-10 22:47:49 PDT
All reviewed patches have been landed.  Closing bug.