The possibility to load and save history has been removed from the WebKit api. Please bring it back, I'm using this functionality. I think it makes sense for a WebKit client to be able load and save history for persistance between sessions.
The functionality was removed in changesets r150660 and r150665.
Created attachment 204157 [details] Patch
Attachment 204157 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj', u'Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj.filters', u'Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/cf/ChangeLog', u'Source/WebKit/cf/History/BinaryPropertyList.cpp', u'Source/WebKit/cf/History/BinaryPropertyList.h', u'Source/WebKit/cf/History/HistoryPropertyList.cpp', u'Source/WebKit/cf/History/HistoryPropertyList.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/BinaryPropertyList.cpp', u'Source/WebKit/mac/History/BinaryPropertyList.h', u'Source/WebKit/mac/History/HistoryPropertyList.cpp', u'Source/WebKit/mac/History/HistoryPropertyList.h', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/Interfaces/IWebHistory.idl', u'Source/WebKit/win/Interfaces/IWebHistoryPrivate.idl', u'Source/WebKit/win/WebHistory.cpp', u'Source/WebKit/win/WebHistory.h']" exit_code: 1 Source/WebKit/win/WebHistory.h:65: Extra space after ( in function call [whitespace/parens] [4] Source/WebKit/win/WebHistory.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:67: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:67: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.h:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:70: Extra space after ( in function call [whitespace/parens] [4] Source/WebKit/win/WebHistory.h:71: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:72: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:143: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.h:143: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.h:144: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.h:144: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.cpp:237: Extra space after ( in function call [whitespace/parens] [4] Source/WebKit/win/WebHistory.cpp:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.cpp:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.cpp:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.cpp:274: Should have a space between // and comment [whitespace/comments] [4] Source/WebKit/win/WebHistory.cpp:356: Extra space after ( in function call [whitespace/parens] [4] Source/WebKit/win/WebHistory.cpp:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.cpp:358: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.cpp:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 23 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 204157 [details] Patch Attachment 204157 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/811272
Comment on attachment 204157 [details] Patch Attachment 204157 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/780179
Created attachment 204161 [details] Patch
Attachment 204161 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj', u'Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj.filters', u'Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/cf/ChangeLog', u'Source/WebKit/cf/History/BinaryPropertyList.cpp', u'Source/WebKit/cf/History/BinaryPropertyList.h', u'Source/WebKit/cf/History/HistoryPropertyList.cpp', u'Source/WebKit/cf/History/HistoryPropertyList.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/BinaryPropertyList.cpp', u'Source/WebKit/mac/History/BinaryPropertyList.h', u'Source/WebKit/mac/History/HistoryPropertyList.cpp', u'Source/WebKit/mac/History/HistoryPropertyList.h', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/Interfaces/IWebHistory.idl', u'Source/WebKit/win/Interfaces/IWebHistoryPrivate.idl', u'Source/WebKit/win/WebHistory.cpp', u'Source/WebKit/win/WebHistory.h']" exit_code: 1 Source/WebKit/cf/History/HistoryPropertyList.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebKit/cf/History/HistoryPropertyList.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebKit/win/WebHistory.h:65: Extra space after ( in function call [whitespace/parens] [4] Source/WebKit/win/WebHistory.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:67: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:67: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.h:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:70: Extra space after ( in function call [whitespace/parens] [4] Source/WebKit/win/WebHistory.h:71: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:72: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.h:143: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.h:143: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.h:144: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/win/WebHistory.h:144: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/cf/History/BinaryPropertyList.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebKit/cf/History/BinaryPropertyList.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebKit/win/WebHistory.cpp:237: Extra space after ( in function call [whitespace/parens] [4] Source/WebKit/win/WebHistory.cpp:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.cpp:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.cpp:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.cpp:274: Should have a space between // and comment [whitespace/comments] [4] Source/WebKit/win/WebHistory.cpp:356: Extra space after ( in function call [whitespace/parens] [4] Source/WebKit/win/WebHistory.cpp:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.cpp:358: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebHistory.cpp:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 27 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 204161 [details] Patch Attachment 204161 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/753551
Comment on attachment 204161 [details] Patch I think the consensus is that it was a bad idea to put a history API in WebKit proper. You should be able to replicate this functionality yourself using the IWebHistory API.
(In reply to comment #9) > (From update of attachment 204161 [details]) > I think the consensus is that it was a bad idea to put a history API in WebKit proper. You should be able to replicate this functionality yourself using the IWebHistory API. But isn't the api to load/save history available on the Mac platform? If so, shouldn't the api also be available on Windows?
(In reply to comment #9) > (From update of attachment 204161 [details]) > I think the consensus is that it was a bad idea to put a history API in WebKit proper. You should be able to replicate this functionality yourself using the IWebHistory API. I also think that the ability to load/save history is one of the main features of a history api.
(In reply to comment #9) > (From update of attachment 204161 [details]) > I think the consensus is that it was a bad idea to put a history API in WebKit proper. You should be able to replicate this functionality yourself using the IWebHistory API. So there's no chance of getting this back in? ;)