WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
117397
[CSS Regions] Rename region-overflow to region-fragment
https://bugs.webkit.org/show_bug.cgi?id=117397
Summary
[CSS Regions] Rename region-overflow to region-fragment
Radu Stavila
Reported
2013-06-10 01:38:11 PDT
Rename region-overflow to region-fragment
Attachments
Patch
(37.47 KB, patch)
2013-06-10 05:03 PDT
,
Radu Stavila
no flags
Details
Formatted Diff
Diff
Patch
(40.90 KB, patch)
2013-06-10 06:14 PDT
,
Radu Stavila
no flags
Details
Formatted Diff
Diff
Patch
(40.98 KB, patch)
2013-06-10 06:44 PDT
,
Radu Stavila
no flags
Details
Formatted Diff
Diff
Patch
(41.05 KB, patch)
2013-06-10 06:50 PDT
,
Radu Stavila
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Radu Stavila
Comment 1
2013-06-10 05:03:19 PDT
Created
attachment 204154
[details]
Patch
Mihnea Ovidenie
Comment 2
2013-06-10 05:37:38 PDT
Comment on
attachment 204154
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=204154&action=review
> LayoutTests/ChangeLog:8 > + at
http://www.w3.org/TR/css3-regions/#the-region-fragment-property
Should we put this link:
http://www.w3.org/TR/2013/WD-css3-regions-20130528
instead of the latest WD link?
> LayoutTests/ChangeLog:27 > + (testComputedStyleWebKitRegionFragment):
I would remove these lines from the changelog, i don't think changes to these functions should be mentioned in the changelog.
> LayoutTests/ChangeLog:30 > + (testComputedStyle):
Same here.
> PerformanceTests/ChangeLog:12 > + (.region):
I would remove this line too.
Radu Stavila
Comment 3
2013-06-10 06:14:01 PDT
Created
attachment 204158
[details]
Patch
Alexander Pavlov (apavlov)
Comment 4
2013-06-10 06:25:51 PDT
Comment on
attachment 204158
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=204158&action=review
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:372 > + CSSPropertyWebkitRegionFragment,
Not sure if this is intended to be alpha-sorted; just a note.
Radu Stavila
Comment 5
2013-06-10 06:28:36 PDT
Comment on
attachment 204158
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=204158&action=review
>> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:372 >> + CSSPropertyWebkitRegionFragment, > > Not sure if this is intended to be alpha-sorted; just a note.
Since RegionOverflow was already before RegionBreakAfter, I don't believe it was alpha sorted.
Radu Stavila
Comment 6
2013-06-10 06:44:50 PDT
Created
attachment 204159
[details]
Patch
Radu Stavila
Comment 7
2013-06-10 06:50:00 PDT
Created
attachment 204160
[details]
Patch
WebKit Commit Bot
Comment 8
2013-06-10 07:19:22 PDT
Comment on
attachment 204160
[details]
Patch Clearing flags on attachment: 204160 Committed
r151394
: <
http://trac.webkit.org/changeset/151394
>
WebKit Commit Bot
Comment 9
2013-06-10 07:19:25 PDT
All reviewed patches have been landed. Closing bug.
Zoltan Horvath
Comment 10
2013-06-13 11:02:44 PDT
***
Bug 103686
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug