Bug 117397 - [CSS Regions] Rename region-overflow to region-fragment
Summary: [CSS Regions] Rename region-overflow to region-fragment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Radu Stavila
URL:
Keywords:
: 103686 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-06-10 01:38 PDT by Radu Stavila
Modified: 2013-06-13 11:02 PDT (History)
10 users (show)

See Also:

Attachments
Patch (37.47 KB, patch)
2013-06-10 05:03 PDT, Radu Stavila 		no flags Details | Formatted Diff | Diff
Patch (40.90 KB, patch)
2013-06-10 06:14 PDT, Radu Stavila 		no flags Details | Formatted Diff | Diff
Patch (40.98 KB, patch)
2013-06-10 06:44 PDT, Radu Stavila 		no flags Details | Formatted Diff | Diff
Patch (41.05 KB, patch)
2013-06-10 06:50 PDT, Radu Stavila 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Radu Stavila 2013-06-10 01:38:11 PDT 
Rename region-overflow to region-fragment
Comment 1 Radu Stavila 2013-06-10 05:03:19 PDT 
Created attachment 204154 [details]
Patch
Comment 2 Mihnea Ovidenie 2013-06-10 05:37:38 PDT 
Comment on attachment 204154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204154&action=review

> LayoutTests/ChangeLog:8
> +        at http://www.w3.org/TR/css3-regions/#the-region-fragment-property

Should we put this link: http://www.w3.org/TR/2013/WD-css3-regions-20130528 instead of the latest WD link?

> LayoutTests/ChangeLog:27
> +        (testComputedStyleWebKitRegionFragment):

I would remove these lines from the changelog, i don't think changes to these functions should be mentioned in the changelog.

> LayoutTests/ChangeLog:30
> +        (testComputedStyle):

Same here.

> PerformanceTests/ChangeLog:12
> +        (.region):

I would remove this line too.
Comment 3 Radu Stavila 2013-06-10 06:14:01 PDT 
Created attachment 204158 [details]
Patch
Comment 4 Alexander Pavlov (apavlov) 2013-06-10 06:25:51 PDT 
Comment on attachment 204158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204158&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:372
> +    CSSPropertyWebkitRegionFragment,

Not sure if this is intended to be alpha-sorted; just a note.
Comment 5 Radu Stavila 2013-06-10 06:28:36 PDT 
Comment on attachment 204158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204158&action=review

>> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:372
>> +    CSSPropertyWebkitRegionFragment,
> 
> Not sure if this is intended to be alpha-sorted; just a note.

Since RegionOverflow was already before RegionBreakAfter, I don't believe it was alpha sorted.
Comment 6 Radu Stavila 2013-06-10 06:44:50 PDT 
Created attachment 204159 [details]
Patch
Comment 7 Radu Stavila 2013-06-10 06:50:00 PDT 
Created attachment 204160 [details]
Patch
Comment 8 WebKit Commit Bot 2013-06-10 07:19:22 PDT 
Comment on attachment 204160 [details]
Patch

Clearing flags on attachment: 204160

Committed r151394: <http://trac.webkit.org/changeset/151394>
Comment 9 WebKit Commit Bot 2013-06-10 07:19:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Zoltan Horvath 2013-06-13 11:02:44 PDT 
*** Bug 103686 has been marked as a duplicate of this bug. ***