RenderNamedFlowThread layers should not be composited and their collected children layers should be inspected by means of their associated regions.
Created attachment 204140 [details] Patch
Attachment 204140 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/regions/assert-flow-thread-compositing-expected.txt', u'LayoutTests/fast/regions/assert-flow-thread-compositing.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderLayerCompositor.cpp']" exit_code: 1 Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 204150 [details] Patch 2 Add missing bail-out in RenderLayerCompositor::rebuildCompositingLayerTree
*** Bug 117404 has been marked as a duplicate of this bug. ***
Comment on attachment 204150 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=204150&action=review r=me, but we should also add a bug to fix the initial assert when proper compositing is implemented. > LayoutTests/fast/regions/assert-flow-thread-compositing.html:5 > + .transformed { width: 50px; height: 50px; background-color: salmon; -webkit-transform: translateZ(0px); border: 1px solid black; } nit: just use green instead of salmon :) > Source/WebCore/rendering/RenderLayerCompositor.cpp:926 > + layer->setHasCompositingDescendant(false); nit: I think you don't need this, it's false by default. We are going to fix it for 84900 anyway.
Created attachment 204167 [details] Patch for landing
Comment on attachment 204167 [details] Patch for landing Clearing flags on attachment: 204167 Committed r151396: <http://trac.webkit.org/changeset/151396>
All reviewed patches have been landed. Closing bug.