Bug 117391 – [EFL] Window resize should close the popupmenu

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Santosh Mahto]

Created attachment 204137 [details]
Test page showing popup menu list

In EFL when window is resized the popup menu(<select>) should gets hidden.otherwise
on resizing the popupmenu is incorrectly placed (possibly on different selection box)

We hide the context menu on window resize , in the same way we should hide the popup menu 
This behaviour is observed in windows chrome/firefox

[Santosh Mahto]

Created attachment 204138 [details]
Patch

[Chris Dumez]

Comment on attachment 204138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204138&action=review

> Tools/MiniBrowser/efl/main.c:281
> +        evas_object_del(window->popup.elm_menu);

Please use elm_menu_close() to be consistent with on_popup_menu_hide().

[Santosh Mahto]

Created attachment 204141 [details]
Patch

[Chris Dumez]

Comment on attachment 204141 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204141&action=review

Looks OK, r=me with nit.

> Tools/ChangeLog:7
> +

Please add a changelog before landing.

[kov's GTK+ EWS bot]

Comment on attachment 204141 [details]
Patch

Attachment 204141 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/725615

[Santosh Mahto]

Created attachment 204378 [details]
Patch for landing

[Gyuyoung Kim]

Comment on attachment 204378 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=204378&action=review

> Tools/ChangeLog:6
> +        Reviewed by Christophe Dumez.

Need to add a new line.

[Santosh Mahto]

Created attachment 204381 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 204381 [details]
Patch for landing

Clearing flags on attachment: 204381

Committed r151483: <http://trac.webkit.org/changeset/151483>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.