Bug 117384 - [CoordinatedGraphics] Typo in argument decoder for CoordinatedGraphicsState
Summary: [CoordinatedGraphics] Typo in argument decoder for CoordinatedGraphicsState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-09 12:04 PDT by Ralph T
Modified: 2013-06-09 23:25 PDT (History)
10 users (show)

See Also:


Attachments
Patch (1.61 KB, patch)
2013-06-09 17:51 PDT, Jae Hyun Park
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (631.13 KB, application/zip)
2013-06-09 18:42 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph T 2013-06-09 12:04:08 PDT
I noticed that CoordinatedGraphicsArgumentCoders.cpp:1187 is wrong for CSS shaders, it currently reads:

    if (!decoder.decode(state.updateAtlasesToRemove))
        return false;

But it should say:

    if (!decoder.decode(state.customFiltersToRemove))
        return false;
Comment 1 Jae Hyun Park 2013-06-09 17:51:33 PDT
Created attachment 204128 [details]
Patch
Comment 2 Jae Hyun Park 2013-06-09 17:53:14 PDT
(In reply to comment #0)
> I noticed that CoordinatedGraphicsArgumentCoders.cpp:1187 is wrong for CSS shaders, it currently reads:
> 
>     if (!decoder.decode(state.updateAtlasesToRemove))
>         return false;
> 
> But it should say:
> 
>     if (!decoder.decode(state.customFiltersToRemove))
>         return false;

Thanks for reporting! 
I quickly made a patch to fix this. I hope you don't mind.
Comment 3 Build Bot 2013-06-09 18:42:34 PDT
Comment on attachment 204128 [details]
Patch

Attachment 204128 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/803133

New failing tests:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html
Comment 4 Build Bot 2013-06-09 18:42:36 PDT
Created attachment 204131 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 5 Ralph T 2013-06-09 21:29:14 PDT
(In reply to comment #2)
> Thanks for reporting! 
> I quickly made a patch to fix this. I hope you don't mind.

Not at all, thanks for being proactive :).
Comment 6 Noam Rosenthal 2013-06-09 23:05:08 PDT
Comment on attachment 204128 [details]
Patch

EWS responds to a flaky test, this code does not get compiled on Mac.
Comment 7 WebKit Commit Bot 2013-06-09 23:25:54 PDT
Comment on attachment 204128 [details]
Patch

Clearing flags on attachment: 204128

Committed r151364: <http://trac.webkit.org/changeset/151364>
Comment 8 WebKit Commit Bot 2013-06-09 23:25:57 PDT
All reviewed patches have been landed.  Closing bug.