Bug 117384 – [CoordinatedGraphics] Typo in argument decoder for CoordinatedGraphicsState

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Ralph T]

I noticed that CoordinatedGraphicsArgumentCoders.cpp:1187 is wrong for CSS shaders, it currently reads:

    if (!decoder.decode(state.updateAtlasesToRemove))
        return false;

But it should say:

    if (!decoder.decode(state.customFiltersToRemove))
        return false;

[Jae Hyun Park]

Created attachment 204128 [details]
Patch

[Jae Hyun Park]

(In reply to comment #0)
> I noticed that CoordinatedGraphicsArgumentCoders.cpp:1187 is wrong for CSS shaders, it currently reads:
> 
>     if (!decoder.decode(state.updateAtlasesToRemove))
>         return false;
> 
> But it should say:
> 
>     if (!decoder.decode(state.customFiltersToRemove))
>         return false;

Thanks for reporting! 
I quickly made a patch to fix this. I hope you don't mind.

[Build Bot]

Comment on attachment 204128 [details]
Patch

Attachment 204128 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/803133

New failing tests:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html

[Build Bot]

Created attachment 204131 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Ralph T]

(In reply to comment #2)
> Thanks for reporting! 
> I quickly made a patch to fix this. I hope you don't mind.

Not at all, thanks for being proactive :).

[Noam Rosenthal]

Comment on attachment 204128 [details]
Patch

EWS responds to a flaky test, this code does not get compiled on Mac.

[WebKit Commit Bot]

Comment on attachment 204128 [details]
Patch

Clearing flags on attachment: 204128

Committed r151364: <http://trac.webkit.org/changeset/151364>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.