RESOLVED INVALID 117382
[WinCairo] Compile errors in WebCore. 
https://bugs.webkit.org/show_bug.cgi?id=117382
Summary [WinCairo] Compile errors in WebCore.
peavo
Reported 2013-06-09 06:00:33 PDT
Compiling MediaQueryEvaluator.cpp fails: webkit\source\webcore\css\MediaQueryEvaluator.cpp(599): error C2065: 'CSSValueWindowed' : undeclared identifier
Attachments
Patch (1.49 KB, patch)
2013-06-09 06:11 PDT, peavo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2013-06-09 06:11:03 PDT
Created attachment 204119 [details] Patch
peavo
Comment 2 2013-06-09 06:16:30 PDT
The file FeatureDefinesCairo.props has set the mime type as application/xml, so I was not able to get a sensible diff from the previous version. I changed <ENABLE_VIEW_MODE_CSS_MEDIA /> to <ENABLE_VIEW_MODE_CSS_MEDIA>ENABLE_VIEW_MODE_CSS_MEDIA</ENABLE_VIEW_MODE_CSS_MEDIA>. The define not only needs to be defined, but also have a value. I also deleted the mime type.
Brent Fulgham
Comment 3 2013-06-13 09:58:24 PDT
This patch isn't doing the right thing. The change you proposed basically turns on the VIEW_MODE_CSS_MEDIA feature, which we don't really want (at the moment) because we don't have any active media features in WinCairo. I filed a separate bug (Bug 114369) that is the root of the problem. Basically, even though we say "don't build with the VIEW_MODE_CSS_MEDIA feature" in our FeatureDefineCairo.props file, FeatureDefines.h just flips it back on. Let's move the conversation to that bug. I'm closing this issue, as we don't want to fix the problem this way.
Daniel Bates
Comment 4 2013-06-13 15:54:01 PDT
Comment on attachment 204119 [details] Patch Clearing review- and commit queue- flag so that this patch doesn't appear in the review queue and commit queue, respectively.
Note You need to log in before you can comment on or make changes to this bug.